public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rasesh Mody <rmody@brocade.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	adapter_linux_open_src_team@Brocade.COM
Subject: Re: [net-next 12/13] bna: Firmware Patch Simplification
Date: Wed, 20 Nov 2013 22:26:20 -0800	[thread overview]
Message-ID: <1385015180.2164.42.camel@joe-AO722> (raw)
In-Reply-To: <1385013257-32745-13-git-send-email-rmody@brocade.com>

On Wed, 2013-11-20 at 21:54 -0800, Rasesh Mody wrote:
> This patch includes change to enable firmware patch simplication feature.
> This feature is targeted to address the requirement to have independent patch
> release for firmware. Prior to the 3.2.3.0 firmware, releasing a patch fix for
> firmware would require changes to bna driver, to use new firmware images.
> However with these changes, if the new firmware is flashed on to the Adapter,
> the driver will use the new firmware after checking the patch release byte in
> the firmware version.

Please run your patches through checkpatch --strict

> +/* flash command register data structure */
> +union bfa_flash_cmd_reg {
> +	struct {
> +#ifdef __BIGENDIAN

__BIG_ENDIAN?

> +/* flash device status register data structure */
> +union bfa_flash_dev_status_reg {
> +	struct {
> +#ifdef __BIGENDIAN

__BIG_ENDIAN here too?

> +/* flash address register data structure */
> +union bfa_flash_addr_reg {
> +	struct {
> +#ifdef __BIGENDIAN

and here

  reply	other threads:[~2013-11-21  6:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  5:54 [net-next 00/13] bna: Update the Driver to v3.2.23.0 Rasesh Mody
2013-11-21  5:54 ` [net-next 01/13] bna: Add software PTP support Rasesh Mody
2013-11-21  5:54 ` [net-next 02/13] bna: Set Get IOC fw State Rasesh Mody
2013-11-21  5:54 ` [net-next 03/13] bna: Fix Filter Add Del Rasesh Mody
2013-11-21  5:54 ` [net-next 04/13] bna: RX Filter Enhancements Rasesh Mody
2013-11-21  5:54 ` [net-next 05/13] bna: Enable Multi Buffer RX Rasesh Mody
2013-11-21  5:54 ` [net-next 06/13] bna: UDP RX Processing Improvements Rasesh Mody
2013-11-21  5:54 ` [net-next 07/13] bna: Fix Stale MTU used to Configure Multi-buffer RX Rasesh Mody
2013-11-21  5:54 ` [net-next 08/13] bna: CQ Read Fix Rasesh Mody
2013-11-21  5:54 ` [net-next 09/13] bna: Add NULL Check Before Dereferencing TCB Rasesh Mody
2013-11-21  5:54 ` [net-next 10/13] bna: Handle the TX Setup Failures Rasesh Mody
2013-11-21  5:54 ` [net-next 11/13] bna: Embed SKB Length in TX Vector Rasesh Mody
2013-11-21  5:54 ` [net-next 12/13] bna: Firmware Patch Simplification Rasesh Mody
2013-11-21  6:26   ` Joe Perches [this message]
2013-11-21  5:54 ` [net-next 13/13] bna: Update the Driver Version to 3.2.23.0 Rasesh Mody
2013-11-21  6:03 ` [net-next 00/13] bna: Update the Driver to v3.2.23.0 David Miller
  -- strict thread matches above, loose matches on Subject: below --
2013-12-08  5:48 Rasesh Mody
2013-12-08  5:48 ` [net-next 12/13] bna: Firmware Patch Simplification Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385015180.2164.42.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=adapter_linux_open_src_team@Brocade.COM \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox