From: Jonas Jensen <jonas.jensen@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jonas Jensen <jonas.jensen@gmail.com>
Subject: [PATCH 5/5] net: MOXA ART: use eth_mac_addr()
Date: Fri, 22 Nov 2013 15:57:22 +0100 [thread overview]
Message-ID: <1385132242-3204-5-git-send-email-jonas.jensen@gmail.com> (raw)
In-Reply-To: <1385132242-3204-1-git-send-email-jonas.jensen@gmail.com>
Replace boilerplate in moxart_set_mac_address() with eth_mac_addr().
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
---
Notes:
Applies to next-20131122
drivers/net/ethernet/moxa/moxart_ether.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index c02075a..9a11d34 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -56,12 +56,7 @@ static void moxart_update_mac_address(struct net_device *ndev)
static int moxart_set_mac_address(struct net_device *ndev, void *addr)
{
- struct sockaddr *address = addr;
-
- if (!is_valid_ether_addr(address->sa_data))
- return -EADDRNOTAVAIL;
-
- memcpy(ndev->dev_addr, address->sa_data, ndev->addr_len);
+ eth_mac_addr(ndev, addr);
moxart_update_mac_address(ndev);
return 0;
--
1.8.2.1
prev parent reply other threads:[~2013-11-22 14:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 14:57 [PATCH 1/5] net: MOXA ART: clear TX descriptor length bits between sends Jonas Jensen
2013-11-22 14:57 ` [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support Jonas Jensen
2013-11-22 15:20 ` Jonas Jensen
2013-11-22 21:09 ` Florian Fainelli
2013-11-22 21:14 ` Florian Fainelli
2013-11-22 23:48 ` Ben Hutchings
2013-11-22 14:57 ` [PATCH 3/5] net: MOXA ART: add IFF_LIVE_ADDR_CHANGE flag Jonas Jensen
2013-11-22 14:57 ` [PATCH 4/5] net: MOXA ART: generate random address Jonas Jensen
2013-11-22 14:57 ` Jonas Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385132242-3204-5-git-send-email-jonas.jensen@gmail.com \
--to=jonas.jensen@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).