From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 0/5] net: hwmon fixes Date: Mon, 25 Nov 2013 17:15:50 +0000 Message-ID: <1385399750.1586.40.camel@bwh-desktop.uk.level5networks.com> References: <1385186881-7931-1-git-send-email-linux@roeck-us.net> <1385225290.20467.73.camel@deadeye.wl.decadent.org.uk> <5290E0B9.1030606@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , "David S. Miller" , "Jeff Kirsher" , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , "Nithin Nayak Sujir" , Michael Chan , , To: Guenter Roeck Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:56267 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871Ab3KYRP4 (ORCPT ); Mon, 25 Nov 2013 12:15:56 -0500 In-Reply-To: <5290E0B9.1030606@roeck-us.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2013-11-23 at 09:07 -0800, Guenter Roeck wrote: > On 11/23/2013 08:48 AM, Ben Hutchings wrote: > > On Fri, 2013-11-22 at 22:07 -0800, Guenter Roeck wrote: > >> The hwmon subsystem is used by various network drivers to report temperature > >> sensor and other information. Unfortunately, its use is often not correct. > >> Typical errors are that the mandatory name sysfs attribute is not created, > >> that the temperature sensor index starts with 0 instead of 1, and/or that > >> sysfs attributes are created after the hwmon device was created. > > > > As it happens, I was just looking at what we do in sfc > > (drivers/net/ethernet/sfc/mcdi_mon.c) and wondering why I made it create > > the hwmon device before the attributes. I think I avoided the other > > bugs though. > > > Hi Ben, > > Yes, I know about that one. It concluded that it would be too invasive > and risky to try to fix it without access to hardware to test the results. > That is why I said "fixes _most_ of the problems". > > As for why the attributes are created after registration, it was most likely > because there was no API available to attach the sysfs attributes to > the hwmon device in a clean way. The new APIs fix that. We don't attach them to the hwmon device either, and I would rather not change that yet because lm-sensors 2 is still widely used. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.