Re: [PATCH 3/5] ixgbe: Convert to use devm_hwmon_device_register_with_groups

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Fri, 2013-11-22 at 22:07 -0800, Guenter Roeck wrote:
> Simplify the code. Attach hwmon sysfs attributes to hwmon device
> instead of pci device. Avoid race conditions caused by attributes
> being created after hwmon device registration. Implicitly
> (through hwmon API) add mandatory 'name' sysfs attribute.
> 
> Other cleanup:
> 
> Instead of allocating memory for hwmon attributes, move attributes
> and all other hwmon related data into struct hwmon_buff and allocate
> the entire structure using devm_kzalloc.
> 
> Check return value from calls to igb_add_hwmon_attr() one by one
> instead
> of logically combining them all together.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h       |    8 ++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |   76
> ++++++++++--------------
>  2 files changed, 36 insertions(+), 48 deletions(-)

I have added this to my queue, thanks!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]