* [PATCH net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler
@ 2013-11-25 7:48 baker.kernel
2013-11-25 13:44 ` Sergei Shtylyov
2013-11-26 1:29 ` [PATCH v2 " baker.kernel
0 siblings, 2 replies; 4+ messages in thread
From: baker.kernel @ 2013-11-25 7:48 UTC (permalink / raw)
To: davem; +Cc: netdev, Baker Zhang
From: Baker Zhang <Baker.kernel@gmail.com>
since f9242b6b28d61295f2bf7e8adfb1060b382e5381,
there are not pretended hash tables for ipv4 or
ipv6 protocol handler.
Signed-off-by: Baker Zhang <Baker.kernel@gmail.com>
---
inet_add_protocol/inet_del_protocol and inet6_del_protocol
are very simple in current version.
so I remove the outdated comment instead of fixing them,
just like inet6_add_protocol.
net/ipv4/protocol.c | 8 --------
net/ipv6/protocol.c | 4 ----
2 files changed, 12 deletions(-)
diff --git a/net/ipv4/protocol.c b/net/ipv4/protocol.c
index ce84846..46d6a1c 100644
--- a/net/ipv4/protocol.c
+++ b/net/ipv4/protocol.c
@@ -31,10 +31,6 @@
const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;
const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS] __read_mostly;
-/*
- * Add a protocol handler to the hash tables
- */
-
int inet_add_protocol(const struct net_protocol *prot, unsigned char protocol)
{
if (!prot->netns_ok) {
@@ -55,10 +51,6 @@ int inet_add_offload(const struct net_offload *prot, unsigned char protocol)
}
EXPORT_SYMBOL(inet_add_offload);
-/*
- * Remove a protocol from the hash tables.
- */
-
int inet_del_protocol(const struct net_protocol *prot, unsigned char protocol)
{
int ret;
diff --git a/net/ipv6/protocol.c b/net/ipv6/protocol.c
index 22d1bd4..e048cf1 100644
--- a/net/ipv6/protocol.c
+++ b/net/ipv6/protocol.c
@@ -36,10 +36,6 @@ int inet6_add_protocol(const struct inet6_protocol *prot, unsigned char protocol
}
EXPORT_SYMBOL(inet6_add_protocol);
-/*
- * Remove a protocol from the hash tables.
- */
-
int inet6_del_protocol(const struct inet6_protocol *prot, unsigned char protocol)
{
int ret;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler
2013-11-25 7:48 [PATCH net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler baker.kernel
@ 2013-11-25 13:44 ` Sergei Shtylyov
2013-11-26 1:29 ` [PATCH v2 " baker.kernel
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-11-25 13:44 UTC (permalink / raw)
To: baker.kernel, davem; +Cc: netdev
Hello.
On 25-11-2013 11:48, baker.kernel@gmail.com wrote:
> From: Baker Zhang <Baker.kernel@gmail.com>
> since f9242b6b28d61295f2bf7e8adfb1060b382e5381,
Please also specify that commit's summary line in parens.
> there are not pretended hash tables for ipv4 or
> ipv6 protocol handler.
> Signed-off-by: Baker Zhang <Baker.kernel@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler
2013-11-25 7:48 [PATCH net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler baker.kernel
2013-11-25 13:44 ` Sergei Shtylyov
@ 2013-11-26 1:29 ` baker.kernel
2013-11-28 23:48 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: baker.kernel @ 2013-11-26 1:29 UTC (permalink / raw)
To: sergei.shtylyov, davem; +Cc: netdev, Baker Zhang
From: Baker Zhang <Baker.kernel@gmail.com>
since f9242b6b28d61295f2bf7e8adfb1060b382e5381
inet: Sanitize inet{,6} protocol demux.
there are not pretended hash tables for ipv4 or
ipv6 protocol handler.
Signed-off-by: Baker Zhang <Baker.kernel@gmail.com>
---
V1:
inet_add_protocol/inet_del_protocol and inet6_del_protocol
are very simple in current version.
so I remove the outdated comment instead of fixing them,
just like inet6_add_protocol.
V2:
Add summary line in parens.
URL:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f9242b6b28d61295f2bf7e8adfb1060b382e5381
net/ipv4/protocol.c | 8 --------
net/ipv6/protocol.c | 4 ----
2 files changed, 12 deletions(-)
diff --git a/net/ipv4/protocol.c b/net/ipv4/protocol.c
index ce84846..46d6a1c 100644
--- a/net/ipv4/protocol.c
+++ b/net/ipv4/protocol.c
@@ -31,10 +31,6 @@
const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;
const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS] __read_mostly;
-/*
- * Add a protocol handler to the hash tables
- */
-
int inet_add_protocol(const struct net_protocol *prot, unsigned char protocol)
{
if (!prot->netns_ok) {
@@ -55,10 +51,6 @@ int inet_add_offload(const struct net_offload *prot, unsigned char protocol)
}
EXPORT_SYMBOL(inet_add_offload);
-/*
- * Remove a protocol from the hash tables.
- */
-
int inet_del_protocol(const struct net_protocol *prot, unsigned char protocol)
{
int ret;
diff --git a/net/ipv6/protocol.c b/net/ipv6/protocol.c
index 22d1bd4..e048cf1 100644
--- a/net/ipv6/protocol.c
+++ b/net/ipv6/protocol.c
@@ -36,10 +36,6 @@ int inet6_add_protocol(const struct inet6_protocol *prot, unsigned char protocol
}
EXPORT_SYMBOL(inet6_add_protocol);
-/*
- * Remove a protocol from the hash tables.
- */
-
int inet6_del_protocol(const struct inet6_protocol *prot, unsigned char protocol)
{
int ret;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler
2013-11-26 1:29 ` [PATCH v2 " baker.kernel
@ 2013-11-28 23:48 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-11-28 23:48 UTC (permalink / raw)
To: baker.kernel; +Cc: sergei.shtylyov, netdev
From: baker.kernel@gmail.com
Date: Tue, 26 Nov 2013 09:29:15 +0800
> From: Baker Zhang <Baker.kernel@gmail.com>
>
> since f9242b6b28d61295f2bf7e8adfb1060b382e5381
> inet: Sanitize inet{,6} protocol demux.
>
> there are not pretended hash tables for ipv4 or
> ipv6 protocol handler.
>
> Signed-off-by: Baker Zhang <Baker.kernel@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-28 23:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 7:48 [PATCH net-next] net: remove outdated comment for ipv4 and ipv6 protocol handler baker.kernel
2013-11-25 13:44 ` Sergei Shtylyov
2013-11-26 1:29 ` [PATCH v2 " baker.kernel
2013-11-28 23:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).