Re: [PATCH 15/17] net: sfc calls skb_get_rxhash

[Ben Hutchings <bhutchings@solarflare.com>]

On Mon, 2013-11-25 at 21:57 -0800, Tom Herbert wrote:
> Drivers should call skb_get_rxhash to set the rxhash and its type
> in an skbuff.
> 
> Signed-off-by: Tom Herbert <therbert@google.com>
> ---
>  drivers/net/ethernet/sfc/rx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c
> index 8f09e68..b51466e 100644
> --- a/drivers/net/ethernet/sfc/rx.c
> +++ b/drivers/net/ethernet/sfc/rx.c
> @@ -439,7 +439,8 @@ efx_rx_packet_gro(struct efx_channel *channel, struct efx_rx_buffer *rx_buf,
>  	}
>  
>  	if (efx->net_dev->features & NETIF_F_RXHASH)
> -		skb->rxhash = efx_rx_buf_hash(efx, eh);
> +		skb_set_rxhash(skb, efx_rx_buf_hash(efx, eh),
> +			       RXHASH_TYPE_L3);

This is equivalent to what we do now.  But efx_rx_packet_gro() is only
ever called for TCP packets (checked in __efx_rx_packet()) and their
hashes include port numbers, so the hash type could be RXHASH_TYPE_L4.

Ben.

>  	skb->ip_summed = ((rx_buf->flags & EFX_RX_PKT_CSUMMED) ?
>  			  CHECKSUM_UNNECESSARY : CHECKSUM_NONE);
>  

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.