From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 15/17] net: sfc calls skb_get_rxhash Date: Wed, 27 Nov 2013 00:05:23 +0000 Message-ID: <1385510723.1586.68.camel@bwh-desktop.uk.level5networks.com> References: <1385495957.1586.54.camel@bwh-desktop.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Netdev List To: Tom Herbert Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:46309 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803Ab3K0AF2 (ORCPT ); Tue, 26 Nov 2013 19:05:28 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2013-11-26 at 15:35 -0800, Tom Herbert wrote: > On Tue, Nov 26, 2013 at 11:59 AM, Ben Hutchings > wrote: > > On Mon, 2013-11-25 at 21:57 -0800, Tom Herbert wrote: > >> Drivers should call skb_get_rxhash to set the rxhash and its type > >> in an skbuff. > >> > >> Signed-off-by: Tom Herbert > >> --- > >> drivers/net/ethernet/sfc/rx.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c > >> index 8f09e68..b51466e 100644 > >> --- a/drivers/net/ethernet/sfc/rx.c > >> +++ b/drivers/net/ethernet/sfc/rx.c > >> @@ -439,7 +439,8 @@ efx_rx_packet_gro(struct efx_channel *channel, struct efx_rx_buffer *rx_buf, > >> } > >> > >> if (efx->net_dev->features & NETIF_F_RXHASH) > >> - skb->rxhash = efx_rx_buf_hash(efx, eh); > >> + skb_set_rxhash(skb, efx_rx_buf_hash(efx, eh), > >> + RXHASH_TYPE_L3); > > > > This is equivalent to what we do now. But efx_rx_packet_gro() is only > > ever called for TCP packets (checked in __efx_rx_packet()) and their > > hashes include port numbers, so the hash type could be RXHASH_TYPE_L4. > > > It would be great for sfc (and more drivers) to provide L4 hash. I > think we should fix the API first and then fix drivers to return L4. OK, so: Acked-by: Ben Hutchings Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.