From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
rkuo <rkuo@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case
Date: Mon, 02 Dec 2013 15:48:58 +0100 [thread overview]
Message-ID: <1385995738.20277.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1385937499.2664.21.camel@joe-AO722>
On Sun, 2013-12-01 at 14:38 -0800, Joe Perches wrote:
> On Sun, 2013-12-01 at 10:35 +0100, Johannes Berg wrote:
> > Good try, but no, now ap_sdata isn't even assigned. :)
>
> Right. Oh well. There's no improving this without
> significant rewrite. Even then, there may not be much
> overall improvement.
I could see an improvement if we were to actually make changes to assign
the pointer based on the iftype, when that changes, so that each
function only has to handle the right type and we don't need the switch
statement at all...
But that's tricky to get right and I'm between vacations and holidays
and all that ...
johannes
next prev parent reply other threads:[~2013-12-02 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528AEFB7.4060301@gmail.com>
[not found] ` <20131125011938.GB18921@codeaurora.org>
[not found] ` <5292B845.3010404@gmail.com>
[not found] ` <5292B8A0.7020409@gmail.com>
[not found] ` <5294255E.7040105@gmail.com>
2013-11-27 4:53 ` [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case Chen Gang
2013-11-29 15:38 ` Johannes Berg
2013-11-30 11:59 ` Chen Gang
2013-11-30 12:53 ` Johannes Berg
[not found] ` <1385816013.4327.1.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-11-30 13:50 ` Chen Gang
2013-11-30 14:02 ` Chen Gang
2013-11-30 20:08 ` Johannes Berg
2013-11-30 20:39 ` Joe Perches
2013-11-30 23:48 ` Chen Gang
[not found] ` <529A7955.9010507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-30 23:59 ` Chen Gang
2013-12-01 9:37 ` Johannes Berg
[not found] ` <1385890647.4171.3.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-12-01 11:50 ` Chen Gang
2013-12-01 9:35 ` Johannes Berg
2013-12-01 22:38 ` Joe Perches
2013-12-02 0:45 ` Chen Gang
2013-12-02 14:48 ` Johannes Berg [this message]
2013-12-04 2:12 ` Chen Gang
[not found] ` <529E8F90.1020205-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-12-04 8:04 ` Johannes Berg
2013-12-04 8:41 ` Chen Gang
2013-12-04 8:49 ` Johannes Berg
2013-12-04 9:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385995738.20277.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=gang.chen.5i5j@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).