Re: [net-next 09/14] i40e: Enable all PCTYPEs except FCOE for RSS.

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On Sat, 2013-12-07 at 23:12 +0300, Sergei Shtylyov wrote:
> On 12/07/2013 09:16 PM, Jeff Kirsher wrote:
> 
> >>> From: Anjali Singhai Jain <anjali.singhai@intel.com>
> 
> >>> RSS can steer packets based on recognition of all
> >>> sorts of different headers.  Enable some more of them.
> 
> >>> Change-Id: I2264dedae66fb0bceca6fb6e772e050e3ca8efc8
> 
> >>      This line has no place in the upstream patches, and I'm seeing
> it
> >> in
> >> several patches of this series.
> 
> > This is an internal hash id, so that we can track upstream changes
> back
> > to internal git tree changes.  I did verify that this was acceptable
> and
> > is being used in the kernel in upstream patches before pushing this
> > information.
> 
>     First time I hear about that. Its use is constantly denied in
> linux-usb at 
> least. Maybe netdev has its own rules regarding this though...

Take a look at `git log --format=oneline --grep="Change-Id"`
You will see there are instances in arch as well as in wireless and in
other areas as well.  So we are not doing something new or the only ones
using this tag.

Google appears to be using it as well based the following information:
https://gerrit-documentation.storage.googleapis.com/Documentation/2.7/user-changeid.html
Places using gerrit:
http://code.google.com/p/gerrit/wiki/ShowCases
This is the largest example of a "Change-Id:" tag that I know of.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]