From: Nat Gurumoorthy <natg@google.com>
To: nsujir@broadcom.com, mchan@broadcom.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Nat Gurumoorthy <natg@google.com>
Subject: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0
Date: Mon, 9 Dec 2013 10:43:21 -0800 [thread overview]
Message-ID: <1386614601-9453-1-git-send-email-natg@google.com> (raw)
The new tg3 driver leaves REG_BASE_ADDR (PCI config offset 120)
uninitialized. From power on reset this register may have garbage in it. The
Register Base Address register defines the device local address of a
register. The data pointed to by this location is read or written using
the Register Data register (PCI config offset 128). When REG_BASE_ADDR has
garbage any read or write of Register Data Register (PCI 128) will cause the
PCI bus to lock up. The TCO watchdog will fire and bring down the system.
Signed-off-by: Nat Gurumoorthy <natg@google.com>
---
drivers/net/ethernet/broadcom/tg3.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 369b736..9a904fd 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -16499,6 +16499,9 @@ static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent)
/* Clear this out for sanity. */
tw32(TG3PCI_MEM_WIN_BASE_ADDR, 0);
+ /* Clear TG3PCI_REG_BASE_ADDR to prevent hangs. */
+ tw32(TG3PCI_REG_BASE_ADDR, 0);
+
pci_read_config_dword(tp->pdev, TG3PCI_PCISTATE,
&pci_state_reg);
if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 &&
--
1.8.5.1
next reply other threads:[~2013-12-09 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 18:43 Nat Gurumoorthy [this message]
2013-12-09 19:00 ` [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0 Michael Chan
2013-12-09 19:22 ` Natarajan Gurumoorthy
2013-12-09 21:18 ` Sergei Shtylyov
2013-12-09 21:07 ` Michael Chan
2013-12-10 6:58 ` Michael Chan
2013-12-10 15:01 ` Natarajan Gurumoorthy
2013-12-10 18:40 ` Michael Chan
2013-12-10 18:43 ` David Miller
2013-12-10 18:49 ` Michael Chan
2013-12-11 3:23 ` David Miller
2013-12-11 23:21 ` Michael Chan
2013-12-12 0:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386614601-9453-1-git-send-email-natg@google.com \
--to=natg@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).