Netdev List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net 2/8] sfc: PTP: Moderate log message on event queue overflow
Date: Tue, 10 Dec 2013 18:15:53 -0800	[thread overview]
Message-ID: <1386728153.8168.27.camel@joe-AO722> (raw)
In-Reply-To: <1386726826.1516.238.camel@bwh-desktop.uk.level5networks.com>

On Wed, 2013-12-11 at 01:53 +0000, Ben Hutchings wrote:
> From: Laurence Evans <levans@solarflare.com>
[]
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
[]
> @@ -270,6 +271,7 @@ struct efx_ptp_data {
>  	struct list_head evt_list;
>  	struct list_head evt_free_list;
>  	spinlock_t evt_lock;
> +	bool evt_overflow;

It might be nice to move the bools in this struct together
to reduce the number of struct holes.

  reply	other threads:[~2013-12-11  2:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  1:53 [PATCH net 2/8] sfc: PTP: Moderate log message on event queue overflow Ben Hutchings
2013-12-11  2:15 ` Joe Perches [this message]
2013-12-11  2:20   ` Ben Hutchings
  -- strict thread matches above, loose matches on Subject: below --
2013-12-11  1:51 Pull request: sfc 2013-12-10 Ben Hutchings
2013-12-11  1:55 ` [PATCH net 2/8] sfc: PTP: Moderate log message on event queue overflow Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386728153.8168.27.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox