From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Stefan Assmann <sassmann@kpanic.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
e1000-devel@lists.sourceforge.net, carolyn.wyborny@intel.com
Subject: Re: [PATCH net-next] igb: enable VLAN stripping for VMs with i350
Date: Wed, 11 Dec 2013 06:05:49 -0800 [thread overview]
Message-ID: <1386770749.2204.17.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1386754354-22039-1-git-send-email-sassmann@kpanic.de>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On Wed, 2013-12-11 at 10:32 +0100, Stefan Assmann wrote:
> For i350 VLAN stripping for VMs is not enabled in the VMOLR register
> but in
> the DVMOLR register. Making the changes accordingly. It's not
> necessary to
> unset the E1000_VMOLR_STRVLAN bit on i350 as the hardware will simply
> ignore
> it.
>
> Without this change if a VLAN is configured for a VF assigned to a
> guest
> via (i.e.)
> ip link set p1p1 vf 0 vlan 10
> the VLAN tag will not be stripped from packets going into the VM.
> Which they
> should be because the VM itself is not aware of the VLAN at all.
>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
> drivers/net/ethernet/intel/igb/e1000_82575.h | 4 ++++
> drivers/net/ethernet/intel/igb/e1000_regs.h | 1 +
> drivers/net/ethernet/intel/igb/igb_main.c | 7 +++++++
> 3 files changed, 12 insertions(+)
Thanks Stefan, I have added this patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-11 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 9:32 [PATCH net-next] igb: enable VLAN stripping for VMs with i350 Stefan Assmann
2013-12-11 14:05 ` Jeff Kirsher [this message]
2014-02-08 5:29 ` Aaron Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386770749.2204.17.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=sassmann@kpanic.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).