netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Timo Teräs" <timo.teras@iki.fi>
To: netdev@vger.kernel.org
Cc: "Timo Teräs" <timo.teras@iki.fi>, "Pravin B Shelar" <pshelar@nicira.com>
Subject: [PATCH net] ip_gre: fix msg_name parsing for recvfrom/recvmsg
Date: Thu, 12 Dec 2013 10:53:52 +0200	[thread overview]
Message-ID: <1386838432-18889-1-git-send-email-timo.teras@iki.fi> (raw)

ipgre_header_parse() needs to parse the tunnel's ip header for getting
the link-layer addresses, and uses mac_header to get the header. This
fixes setting mac_header on the receive path to original behaviour.

Bug added in commit c54419321455 (GRE: Refactor GRE tunneling code.)

Cc: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
---
Alternate would be to do skb_reset_inner_headers() in ip_tunnel_rcv() and
update ipgre_header_parse() to use skb_inner_network_header(). Though, then
inner would then be referring to the "outer" headers.

If applied as-is, should go to -stable too.

 net/ipv4/ip_gre.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index d7aea4c..cc2c7f1 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -217,6 +217,7 @@ static int ipgre_rcv(struct sk_buff *skb, const struct tnl_ptk_info *tpi)
 				  iph->saddr, iph->daddr, tpi->key);
 
 	if (tunnel) {
+		skb->mac_header = skb->network_header;
 		ip_tunnel_rcv(tunnel, skb, tpi, log_ecn_error);
 		return PACKET_RCVD;
 	}
-- 
1.8.5.1

             reply	other threads:[~2013-12-12  8:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  8:53 Timo Teräs [this message]
2013-12-12 20:34 ` [PATCH net] ip_gre: fix msg_name parsing for recvfrom/recvmsg David Miller
2013-12-13  6:08   ` Timo Teras
2013-12-14  5:52     ` David Miller
2013-12-16  9:02       ` [PATCH net,v2] " Timo Teräs
2013-12-18 22:45         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386838432-18889-1-git-send-email-timo.teras@iki.fi \
    --to=timo.teras@iki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).