[PATCH v2 net-next] packet: fix using smp_processor

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
       [not found] ` <52A83699.9010504@redhat.com>
@ 2013-12-12 22:51   ` Li Zhong
  2013-12-12  7:19     ` Jesper Dangaard Brouer
                       ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Li Zhong @ 2013-12-12 22:51 UTC (permalink / raw)
  To: Daniel Borkmann, NetDev; +Cc: brouer, davem

This patches tries to fix the following warning on next-1211 by
replacing smp_processor_id() with raw_smp_processor_id(). 

[   11.120893] BUG: using smp_processor_id() in preemptible [00000000] code: arping/3510
[   11.120913] caller is .packet_sendmsg+0xc14/0xe68
[   11.120920] CPU: 13 PID: 3510 Comm: arping Not tainted 3.13.0-rc3-next-20131211-dirty #1
[   11.120926] Call Trace:
[   11.120932] [c0000001f803f6f0] [c0000000000138dc] .show_stack+0x110/0x25c (unreliable)
[   11.120942] [c0000001f803f7e0] [c00000000083dd24] .dump_stack+0xa0/0x37c
[   11.120951] [c0000001f803f870] [c000000000493fd4] .debug_smp_processor_id+0xfc/0x12c
[   11.120959] [c0000001f803f900] [c0000000007eba78] .packet_sendmsg+0xc14/0xe68
[   11.120968] [c0000001f803fa80] [c000000000700968] .sock_sendmsg+0xa0/0xe0
[   11.120975] [c0000001f803fbf0] [c0000000007014d8] .SyS_sendto+0x100/0x148
[   11.120983] [c0000001f803fd60] [c0000000006fff10] .SyS_socketcall+0x1c4/0x2e8
[   11.120990] [c0000001f803fe30] [c00000000000a1e4] syscall_exit+0x0/0x9c

Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
v2: as Daniel suggested, removed the part about setting queue_mapping 

 net/packet/af_packet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 9d70f13..cc803c6 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -310,7 +310,7 @@ static bool packet_use_direct_xmit(const struct packet_sock *po)
 
 static u16 packet_pick_tx_queue(struct net_device *dev)
 {
-	return (u16) smp_processor_id() % dev->real_num_tx_queues;
+	return (u16) raw_smp_processor_id() % dev->real_num_tx_queues;
 }
 
 /* register_prot_hook must be invoked with the po->bind_lock held,

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
  2013-12-12 22:51   ` [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code Li Zhong
@ 2013-12-12  7:19     ` Jesper Dangaard Brouer
  2013-12-12  7:29     ` Daniel Borkmann
  2013-12-12 21:15     ` David Miller
  2 siblings, 0 replies; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2013-12-12  7:19 UTC (permalink / raw)
  To: Li Zhong; +Cc: Daniel Borkmann, NetDev, brouer, davem

On Fri, 13 Dec 2013 06:51:04 +0800
Li Zhong <zhong@linux.vnet.ibm.com> wrote:

> This patches tries to fix the following warning on next-1211 by
> replacing smp_processor_id() with raw_smp_processor_id(). 
> 
> [   11.120893] BUG: using smp_processor_id() in preemptible [00000000] code: arping/3510
> [   11.120913] caller is .packet_sendmsg+0xc14/0xe68
> [   11.120920] CPU: 13 PID: 3510 Comm: arping Not tainted 3.13.0-rc3-next-20131211-dirty #1
> [   11.120926] Call Trace:
> [   11.120932] [c0000001f803f6f0] [c0000000000138dc] .show_stack+0x110/0x25c (unreliable)
> [   11.120942] [c0000001f803f7e0] [c00000000083dd24] .dump_stack+0xa0/0x37c
> [   11.120951] [c0000001f803f870] [c000000000493fd4] .debug_smp_processor_id+0xfc/0x12c
> [   11.120959] [c0000001f803f900] [c0000000007eba78] .packet_sendmsg+0xc14/0xe68
> [   11.120968] [c0000001f803fa80] [c000000000700968] .sock_sendmsg+0xa0/0xe0
> [   11.120975] [c0000001f803fbf0] [c0000000007014d8] .SyS_sendto+0x100/0x148
> [   11.120983] [c0000001f803fd60] [c0000000006fff10] .SyS_socketcall+0x1c4/0x2e8
> [   11.120990] [c0000001f803fe30] [c00000000000a1e4] syscall_exit+0x0/0x9c
> 
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
> ---
> v2: as Daniel suggested, removed the part about setting queue_mapping 

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
  2013-12-12 22:51   ` [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code Li Zhong
  2013-12-12  7:19     ` Jesper Dangaard Brouer
@ 2013-12-12  7:29     ` Daniel Borkmann
  2013-12-12 21:15     ` David Miller
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel Borkmann @ 2013-12-12  7:29 UTC (permalink / raw)
  To: Li Zhong; +Cc: NetDev, brouer, davem

On 12/12/2013 11:51 PM, Li Zhong wrote:
> This patches tries to fix the following warning on next-1211 by
> replacing smp_processor_id() with raw_smp_processor_id().
>
> [   11.120893] BUG: using smp_processor_id() in preemptible [00000000] code: arping/3510
> [   11.120913] caller is .packet_sendmsg+0xc14/0xe68
> [   11.120920] CPU: 13 PID: 3510 Comm: arping Not tainted 3.13.0-rc3-next-20131211-dirty #1
> [   11.120926] Call Trace:
> [   11.120932] [c0000001f803f6f0] [c0000000000138dc] .show_stack+0x110/0x25c (unreliable)
> [   11.120942] [c0000001f803f7e0] [c00000000083dd24] .dump_stack+0xa0/0x37c
> [   11.120951] [c0000001f803f870] [c000000000493fd4] .debug_smp_processor_id+0xfc/0x12c
> [   11.120959] [c0000001f803f900] [c0000000007eba78] .packet_sendmsg+0xc14/0xe68
> [   11.120968] [c0000001f803fa80] [c000000000700968] .sock_sendmsg+0xa0/0xe0
> [   11.120975] [c0000001f803fbf0] [c0000000007014d8] .SyS_sendto+0x100/0x148
> [   11.120983] [c0000001f803fd60] [c0000000006fff10] .SyS_socketcall+0x1c4/0x2e8
> [   11.120990] [c0000001f803fe30] [c00000000000a1e4] syscall_exit+0x0/0x9c
>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>

Acked-by: Daniel Borkmann <dborkman@redhat.com>

Thanks !

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
  2013-12-12 22:51   ` [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code Li Zhong
  2013-12-12  7:19     ` Jesper Dangaard Brouer
  2013-12-12  7:29     ` Daniel Borkmann
@ 2013-12-12 21:15     ` David Miller
  2013-12-13  1:49       ` Li Zhong
  2 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2013-12-12 21:15 UTC (permalink / raw)
  To: zhong; +Cc: dborkman, netdev, brouer

From: Li Zhong <zhong@linux.vnet.ibm.com>
Date: Fri, 13 Dec 2013 06:51:04 +0800

Please fix the date on your computer.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
  2013-12-12 21:15     ` David Miller
@ 2013-12-13  1:49       ` Li Zhong
  0 siblings, 0 replies; 5+ messages in thread
From: Li Zhong @ 2013-12-13  1:49 UTC (permalink / raw)
  To: David Miller; +Cc: dborkman, netdev, brouer

On Thu, 2013-12-12 at 16:15 -0500, David Miller wrote:
> From: Li Zhong <zhong@linux.vnet.ibm.com>
> Date: Fri, 13 Dec 2013 06:51:04 +0800
> 
> Please fix the date on your computer.
> 
Oh, sorry about that, should be fixed this time. 

I saw Daniel helped to send one with the correct date.

Thanks, Zhong

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-12-13  1:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1386828604.2584.13.camel@ThinkPad-T5421>
     [not found] ` <52A83699.9010504@redhat.com>
2013-12-12 22:51   ` [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code Li Zhong
2013-12-12  7:19     ` Jesper Dangaard Brouer
2013-12-12  7:29     ` Daniel Borkmann
2013-12-12 21:15     ` David Miller
2013-12-13  1:49       ` Li Zhong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).