Re: [PATCH net-next] igb: make local functions static and remove dead code

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1850 bytes --]

On Thu, 2013-12-12 at 12:09 -0800, Stephen Hemminger wrote:
> Make local functions static, and remove unused
> e1000_write_sfp_data_byte.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> ---
>  drivers/net/ethernet/intel/igb/e1000_82575.c |    6 +++---
>  drivers/net/ethernet/intel/igb/e1000_i210.c  |   18
> +++++++++---------
>  drivers/net/ethernet/intel/igb/e1000_i210.h  |    9 ---------
>  drivers/net/ethernet/intel/igb/e1000_phy.c   |    2 +-
>  drivers/net/ethernet/intel/igb/e1000_phy.h   |    1 -
>  drivers/net/ethernet/intel/igb/igb.h         |    2 --
>  drivers/net/ethernet/intel/igb/igb_ptp.c     |    6 ++++--
>  7 files changed, 17 insertions(+), 27 deletions(-)

Did you compile test this patch?  I am guessing no because we got the
following compile errors:
 drivers/net/ethernet/intel/igb/e1000_82575.c:2723: error: static
declaration of
 âigb_get_thermal_sensor_data_genericâ follows non-static declaration
 drivers/net/ethernet/intel/igb/e1000_82575.h:270: note: previous
declaration
 of âigb_get_thermal_sensor_data_genericâ was here
 drivers/net/ethernet/intel/igb/e1000_82575.c:2777: error: static
declaration of
 âigb_init_thermal_sensor_thresh_genericâ follows non-static declaration
 drivers/net/ethernet/intel/igb/e1000_82575.h:269: note: previous
declaration
 of âigb_init_thermal_sensor_thresh_genericâ was here
 make[5]: *** [drivers/net/ethernet/intel/igb/e1000_82575.o] Error 1
 make[5]: *** Waiting for unfinished jobs....
 make[4]: *** [drivers/net/ethernet/intel/igb] Error 2
 make[4]: *** Waiting for unfinished jobs....
 make[3]: *** [drivers/net/ethernet/intel] Error 2
 make[2]: *** [drivers/net/ethernet] Error 2
 make[1]: *** [drivers/net] Error 2
 make: *** [drivers] Error 2

I will work on a v2 to fix up these compiling issues.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]