* [PATCH] bnx2x: downgrade "valid ME register value" message level
@ 2013-12-17 17:51 Michal Schmidt
2013-12-18 6:37 ` Yuval Mintz
2013-12-19 20:17 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michal Schmidt @ 2013-12-17 17:51 UTC (permalink / raw)
To: netdev; +Cc: Ariel Elior
"valid ME register value" is not an error. It should be logged for
debugging only.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
index efa8a15..3dc2537 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
@@ -208,7 +208,7 @@ static int bnx2x_get_vf_id(struct bnx2x *bp, u32 *vf_id)
return -EINVAL;
}
- BNX2X_ERR("valid ME register value: 0x%08x\n", me_reg);
+ DP(BNX2X_MSG_IOV, "valid ME register value: 0x%08x\n", me_reg);
*vf_id = (me_reg & ME_REG_VF_NUM_MASK) >> ME_REG_VF_NUM_SHIFT;
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] bnx2x: downgrade "valid ME register value" message level
2013-12-17 17:51 [PATCH] bnx2x: downgrade "valid ME register value" message level Michal Schmidt
@ 2013-12-18 6:37 ` Yuval Mintz
2013-12-19 20:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Mintz @ 2013-12-18 6:37 UTC (permalink / raw)
To: Michal Schmidt, netdev@vger.kernel.org; +Cc: Ariel Elior
> "valid ME register value" is not an error. It should be logged for
> debugging only.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Yep, that's true; Thanks Michal.
Acked-by: Yuval Mintz <yuvalmin@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> index efa8a15..3dc2537 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> @@ -208,7 +208,7 @@ static int bnx2x_get_vf_id(struct bnx2x *bp, u32
> *vf_id)
> return -EINVAL;
> }
>
> - BNX2X_ERR("valid ME register value: 0x%08x\n", me_reg);
> + DP(BNX2X_MSG_IOV, "valid ME register value: 0x%08x\n", me_reg);
>
> *vf_id = (me_reg & ME_REG_VF_NUM_MASK) >>
> ME_REG_VF_NUM_SHIFT;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bnx2x: downgrade "valid ME register value" message level
2013-12-17 17:51 [PATCH] bnx2x: downgrade "valid ME register value" message level Michal Schmidt
2013-12-18 6:37 ` Yuval Mintz
@ 2013-12-19 20:17 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-19 20:17 UTC (permalink / raw)
To: mschmidt; +Cc: netdev, ariele
From: Michal Schmidt <mschmidt@redhat.com>
Date: Tue, 17 Dec 2013 18:51:25 +0100
> "valid ME register value" is not an error. It should be logged for
> debugging only.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-19 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 17:51 [PATCH] bnx2x: downgrade "valid ME register value" message level Michal Schmidt
2013-12-18 6:37 ` Yuval Mintz
2013-12-19 20:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).