Re: [PATCH net-next 8/9] net: phy: fix checkpatch errors

[Joe Perches <joe@perches.com>]

On Tue, 2013-12-17 at 21:38 -0800, Florian Fainelli wrote:
> checkpatch spotted a few checkpatch errors such as whitespace damages
> and switch/case labels not being on the same column, fix them.

trivia:

> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
[]
> @@ -714,16 +714,16 @@ void phy_start(struct phy_device *phydev)
>  	mutex_lock(&phydev->lock);
>  
>  	switch (phydev->state) {
> -		case PHY_STARTING:
> -			phydev->state = PHY_PENDING;
> -			break;
> -		case PHY_READY:
> -			phydev->state = PHY_UP;
> -			break;
> -		case PHY_HALTED:
> -			phydev->state = PHY_RESUMING;
> -		default:
> -			break;
> +	case PHY_STARTING:
> +		phydev->state = PHY_PENDING;
> +		break;
> +	case PHY_READY:
> +		phydev->state = PHY_UP;
> +		break;
> +	case PHY_HALTED:
> +		phydev->state = PHY_RESUMING;

This should have a break here and not
rely on the fallthrough.

> +	default:
> +		break;
>  	}
>  	mutex_unlock(&phydev->lock);
>  }