From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: ieee80211_i.h: shouldn't struct ps_data.tim be aligned unsigned
 long?
Date: Wed, 18 Dec 2013 01:23:05 -0800
Message-ID: <1387358585.13593.40.camel@joe-AO722>
References: <1387354564.13593.26.camel@joe-AO722>
	 (sfid-20131218_091612_149215_EA847147) <1387358347.4694.2.camel@jlt4.sipsolutions.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Jiri Benc <jbenc@redhat.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:47590 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753153Ab3LRJXJ (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 18 Dec 2013 04:23:09 -0500
In-Reply-To: <1387358347.4694.2.camel@jlt4.sipsolutions.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2013-12-18 at 10:19 +0100, Johannes Berg wrote:
> On Wed, 2013-12-18 at 00:16 -0800, Joe Perches wrote:
> 
> > Perhaps the
> > 	u8 tim[sizeof...]
> > member should be marked
> > 	__aligned(sizeof(unsigned long))
> > so that the cast to ulong when bitmap_empty
> > is actually forced to be ulong aligned?
> 
> yeah, I suppose that's true.
> 
> > diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> > index ed5bf8b..e5a9c51 100644
> > --- a/net/mac80211/ieee80211_i.h
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -245,7 +245,8 @@ struct ps_data {
> >  	/* yes, this looks ugly, but guarantees that we can later use
> >  	 * bitmap_empty :)
> >  	 * NB: don't touch this bitmap, use sta_info_{set,clear}_tim_bit */
> > -	u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)];
> > +	u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)]
> > +			__aligned(sizeof(unsigned long));
> 
> Care to send a proper patch? Otherwise I'll just re-do it and pick it up
> that way ...

Hi Johannes.

You can redo it easier than applying a patch
from me.

I just noticed it when the reformatting
patch went by.

No need to give a credit or anything.
It's just a nit.

cheers, Joe