From: Tan Xiaojun <tanxiaojun@huawei.com>
To: <stephen@networkplumber.org>, <davem@davemloft.net>,
<bart.de.schuymer@pandora.be>
Cc: <bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>
Subject: [PATCH 1/5] bridge: remove unnecessary condition judgment
Date: Thu, 19 Dec 2013 13:28:10 +0800 [thread overview]
Message-ID: <1387430894-11220-2-git-send-email-tanxiaojun@huawei.com> (raw)
In-Reply-To: <1387430894-11220-1-git-send-email-tanxiaojun@huawei.com>
Because err is always negative, remove unnecessary condition
judgment.
Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
---
net/bridge/br_fdb.c | 3 +--
net/bridge/br_netlink.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 33e8f23..c5f5a4a 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -570,8 +570,7 @@ static void fdb_notify(struct net_bridge *br,
rtnl_notify(skb, net, 0, RTNLGRP_NEIGH, NULL, GFP_ATOMIC);
return;
errout:
- if (err < 0)
- rtnl_set_sk_err(net, RTNLGRP_NEIGH, err);
+ rtnl_set_sk_err(net, RTNLGRP_NEIGH, err);
}
/* Dump information about entries, in response to GETNEIGH */
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index c2fd6bc..6526ac8 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -195,8 +195,7 @@ void br_ifinfo_notify(int event, struct net_bridge_port *port)
rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
return;
errout:
- if (err < 0)
- rtnl_set_sk_err(net, RTNLGRP_LINK, err);
+ rtnl_set_sk_err(net, RTNLGRP_LINK, err);
}
--
1.8.0
next prev parent reply other threads:[~2013-12-19 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 5:28 [PATCH 0/5] bridge: cleanup and fix checkpatch errors Tan Xiaojun
2013-12-19 5:28 ` Tan Xiaojun [this message]
2013-12-19 5:28 ` [PATCH 2/5] bridge: remove unnecessary parentheses Tan Xiaojun
2013-12-19 5:28 ` [PATCH 3/5] bridge: add space before '(/{', after ',', etc Tan Xiaojun
2013-12-19 5:28 ` [PATCH 4/5] bridge: change "foo* bar" to "foo *bar" Tan Xiaojun
2013-12-19 5:28 ` [PATCH 5/5] bridge: change the position of '{' to the pre line Tan Xiaojun
2013-12-19 6:59 ` [PATCH 0/5] bridge: cleanup and fix checkpatch errors Tan Xiaojun
2013-12-19 18:41 ` Stephen Hemminger
2013-12-20 0:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387430894-11220-2-git-send-email-tanxiaojun@huawei.com \
--to=tanxiaojun@huawei.com \
--cc=bart.de.schuymer@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).