From: Joe Perches <joe@perches.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/9] net: phy: dp83640: fix checkpath error
Date: Thu, 19 Dec 2013 14:31:02 -0800 [thread overview]
Message-ID: <1387492262.2353.26.camel@joe-AO722> (raw)
In-Reply-To: <1387345093-14168-4-git-send-email-f.fainelli@gmail.com>
On Tue, 2013-12-17 at 21:38 -0800, Florian Fainelli wrote:
> diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
[]
> @@ -851,8 +851,8 @@ static int match(struct sk_buff *skb, unsigned int type, struct rxts *rxts)
>
> seqid = (u16 *)(data + offset + OFF_PTP_SEQUENCE_ID);
>
> - return (rxts->msgtype == (*msgtype & 0xf) &&
> - rxts->seqid == ntohs(*seqid));
> + return rxts->msgtype == (*msgtype & 0xf) &&
> + rxts->seqid == ntohs(*seqid);
I think this isn't an improvement.
Maybe:
return rxts->msgtype == (*msgtype & 0xf) &&
rxts->seqid == ntohs(*seqid);
or
return (rxts->msgtype == (*msgtype & 0xf)) &&
(rxts->seqid == ntohs(*seqid));
next prev parent reply other threads:[~2013-12-19 22:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 5:38 [PATCH net-next 0/9] net: phy: fix checkpatch errors Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 1/9] net: phy: cicada: fix checkpath errors Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 2/9] net: phy: davicom: " Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 3/9] net: phy: dp83640: fix checkpath error Florian Fainelli
2013-12-19 22:31 ` Joe Perches [this message]
2013-12-20 9:46 ` David Laight
2013-12-18 5:38 ` [PATCH net-next 4/9] net: phy: icplus: " Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 5/9] net: phy: lxt: fix checkpath errors Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 6/9] net: phy: mdio_bus: fix checkpath error Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 7/9] net: phy: micrel: fix checkpath errors Florian Fainelli
2013-12-18 5:38 ` [PATCH net-next 8/9] net: phy: fix checkpatch errors Florian Fainelli
2013-12-18 6:07 ` Joe Perches
2013-12-19 20:48 ` Sergei Shtylyov
2013-12-18 5:38 ` [PATCH net-next 9/9] net: phy: spi_ks8995: " Florian Fainelli
2013-12-18 5:50 ` [PATCH net-next 0/9] net: phy: " David Miller
2013-12-19 22:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387492262.2353.26.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).