* [PATCH net-next] vmxnet3: use initialized skb pointer to set hash
@ 2013-12-20 12:16 Michal Schmidt
2013-12-20 20:30 ` Tom Herbert
2013-12-26 18:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michal Schmidt @ 2013-12-20 12:16 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Tom Herbert
The recent conversion to skb_set_hash() was incorrect. 'skb' is
uninitialized at this point.
Fixes: 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index c0eab72..3be786f 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
#ifdef VMXNET3_RSS
if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
(adapter->netdev->features & NETIF_F_RXHASH))
- skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
+ skb_set_hash(ctx->skb,
+ le32_to_cpu(rcd->rssHash),
PKT_HASH_TYPE_L3);
#endif
skb_put(ctx->skb, rcd->len);
--
1.8.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] vmxnet3: use initialized skb pointer to set hash
2013-12-20 12:16 [PATCH net-next] vmxnet3: use initialized skb pointer to set hash Michal Schmidt
@ 2013-12-20 20:30 ` Tom Herbert
2013-12-26 18:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tom Herbert @ 2013-12-20 20:30 UTC (permalink / raw)
To: Michal Schmidt; +Cc: David S. Miller, Linux Netdev List
Acked-by: Tom Herbert <therbert@google.com>
On Fri, Dec 20, 2013 at 4:16 AM, Michal Schmidt <mschmidt@redhat.com> wrote:
> The recent conversion to skb_set_hash() was incorrect. 'skb' is
> uninitialized at this point.
>
> Fixes: 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index c0eab72..3be786f 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
> #ifdef VMXNET3_RSS
> if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
> (adapter->netdev->features & NETIF_F_RXHASH))
> - skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
> + skb_set_hash(ctx->skb,
> + le32_to_cpu(rcd->rssHash),
> PKT_HASH_TYPE_L3);
> #endif
> skb_put(ctx->skb, rcd->len);
> --
> 1.8.4.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] vmxnet3: use initialized skb pointer to set hash
2013-12-20 12:16 [PATCH net-next] vmxnet3: use initialized skb pointer to set hash Michal Schmidt
2013-12-20 20:30 ` Tom Herbert
@ 2013-12-26 18:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-26 18:55 UTC (permalink / raw)
To: mschmidt; +Cc: netdev, therbert
From: Michal Schmidt <mschmidt@redhat.com>
Date: Fri, 20 Dec 2013 13:16:57 +0100
> The recent conversion to skb_set_hash() was incorrect. 'skb' is
> uninitialized at this point.
>
> Fixes: 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-26 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 12:16 [PATCH net-next] vmxnet3: use initialized skb pointer to set hash Michal Schmidt
2013-12-20 20:30 ` Tom Herbert
2013-12-26 18:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).