Re: [net-next v2 11/16] i40e: remove chatty log messages

[Joe Perches <joe@perches.com>]

On Fri, 2013-12-20 at 18:04 +0000, Williams, Mitch A wrote:
> > From: Joe Perches [mailto:joe@perches.com]
[]
> > this code is inconsistent and might be
> > nicer using the same form:
> > 
> > 		/* Skip if the queue is already in the requested state */
> > 		if (enable && (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 		if (!enable && !(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 
> > [...]
> > 
> > 		/* wait for the change to finish */
> > 		for (j = 0; j < 10; j++) {
> > 			tx_reg = rd32(hw, I40E_QTX_ENA(pf_q));
> > 			if (enable) {
> > 				if ((tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 					break;
> > 			} else {
> > 				if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 					break;
> > 			}
> > 
> > Perhaps the first form should be like the second
> > 
> > 	if (enable) {
> > 		if (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)
> > 			continue;
> > 	} else {
> > 		if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK))
> > 			continue;
> > 	}
> > 
> > or maybe both should be
> > 
> > 	bool mask = tx_reg & I40E_QTX_ENA_QENA_STAT_MASK;
> > 	if (enable ^ mask)
[]
> I see what you mean about the inconsistent logic. Since it's not
> crucial, I think I'd prefer to fix this in a separate patch in the
> future. (I'll implement it today, but it takes a while to get through
> our internal validation process.)

Whenever, no worries, it's just a nit.