From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: davem@davemloft.net, Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next v3 14/16] i40e: make a define from a large constant
Date: Fri, 20 Dec 2013 12:12:11 -0800 [thread overview]
Message-ID: <1387570331.2183.97.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1387564814.2353.60.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Fri, 2013-12-20 at 10:40 -0800, Joe Perches wrote:
> On Fri, 2013-12-20 at 10:21 -0800, Jeff Kirsher wrote:
> > Make a define used in the header file by both VF and PF drivers.
> []
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> []
> > @@ -66,6 +66,26 @@ enum i40e_dyn_idx_t {
> []
> > +/* Supported RSS offloads */
> > +#define I40E_DEFAULT_RSS_HENA ( \
> > + ((u64)1 << I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) | \
>
> BIT_ULL
>
> > + ((u64)1 << I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP) | \
>
> etc...
>
Joe, I am not seeing widespread use of the macro BIT_ULL, so what is the
driving factor to use the macro? I know you mentioned this on a
previous patch I pushed and wanted to ask then, but simply forgot.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-20 20:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 18:21 [net-next v3 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 01/16] i40e: using for_each_set_bit to simplify the code Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 02/16] i40e: Suppress HMC error to Interrupt message level Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 03/16] i40e: Populate and check pci bus speed and width Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 04/16] i40e: add wake-on-lan support Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 05/16] i40e: fix curly brace use and return type Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 06/16] i40e: Implementation of vxlan ndo's Jeff Kirsher
2013-12-20 21:06 ` Or Gerlitz
2013-12-20 21:49 ` David Miller
2013-12-20 23:25 ` Joseph Gasparakis
2013-12-21 1:41 ` David Miller
2013-12-21 2:14 ` Joseph Gasparakis
2013-12-20 18:21 ` [net-next v3 07/16] i40e: Rx checksum offload for VXLAN Jeff Kirsher
2013-12-20 20:58 ` Or Gerlitz
2013-12-20 18:21 ` [net-next v3 08/16] i40e: move i40e_reset_vf Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 09/16] i40e: refactor VF reset flow Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 10/16] i40e: remove redundant code Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 11/16] i40e: remove chatty log messages Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 12/16] i40e: fix error return Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 13/16] i40e: be more informative Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 14/16] i40e: make a define from a large constant Jeff Kirsher
2013-12-20 18:40 ` Joe Perches
2013-12-20 20:12 ` Jeff Kirsher [this message]
2013-12-20 22:12 ` Joe Perches
2013-12-20 18:21 ` [net-next v3 15/16] i40e: update led set args Jeff Kirsher
2013-12-20 18:21 ` [net-next v3 16/16] i40e: report VF MAC addresses correctly Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387570331.2183.97.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).