Re: [net-next v3 14/16] i40e: make a define from a large constant

[Joe Perches <joe@perches.com>]

On Fri, 2013-12-20 at 12:12 -0800, Jeff Kirsher wrote:
> On Fri, 2013-12-20 at 10:40 -0800, Joe Perches wrote:
> > On Fri, 2013-12-20 at 10:21 -0800, Jeff Kirsher wrote:
> > > Make a define used in the header file by both VF and PF drivers.
> > []
> > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
> > []
> > > @@ -66,6 +66,26 @@ enum i40e_dyn_idx_t {
> > []
> > > +/* Supported RSS offloads */
> > > +#define I40E_DEFAULT_RSS_HENA ( \
> > > +	((u64)1 << I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) | \
> > 
> > BIT_ULL
> > 
> > > +	((u64)1 << I40E_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP) | \
> > 
> > etc...
> > 
> 
> Joe, I am not seeing widespread use of the macro BIT_ULL, so what is the
> driving factor to use the macro?

Hey Jeff.

It was just introduced in October 2013.

commit bfd1ff6375c82930bfb3b401eee2c96720fa8e84
Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date:   Fri Oct 11 16:54:59 2013 -0700

    bitops: Introduce BIT_ULL
    
    Adding BIT(x) equivalent for unsigned long long type, BIT_ULL(x). Also
    added BIT_ULL_MASK and BIT_ULL_WORD.
    

>   I know you mentioned this on a
> previous patch I pushed and wanted to ask then, but simply forgot.

Just consistency and symmetry and a few
bug reduction possibilities using standard
mechanisms.