From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: ogerlitz@mellanox.com, netdev@vger.kernel.org,
amirv@mellanox.com, yanb@mellanox.com, ast@plumgrid.com
Subject: Re: [PATCH net-next V2 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling
Date: Sun, 22 Dec 2013 15:32:39 -0800 [thread overview]
Message-ID: <1387755159.22671.27.camel@joe-AO722> (raw)
In-Reply-To: <20131222.181202.168681767663560253.davem@davemloft.net>
On Sun, 2013-12-22 at 18:12 -0500, David Miller wrote:
> From: Or Gerlitz <ogerlitz@mellanox.com>
> Date: Sun, 22 Dec 2013 17:26:12 +0200
>
> > + if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
> > + if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
> > + if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
> > + (mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
> > + if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
>
> Way too many parenthesis, this isn't LISP :-)
Is patchwork stuttering?
I don't see that in the patch I see.
@@ -2400,6 +2478,13 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
if (mdev->dev->caps.steering_mode != MLX4_STEERING_MODE_A0)
dev->priv_flags |= IFF_UNICAST_FLT;
+ if ((mdev->dev->caps.tunnel_offload_mode == MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)) {
+ dev->hw_enc_features |= NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
+ NETIF_F_TSO | NETIF_F_GSO_UDP_TUNNEL;
+ dev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
+ dev->features |= NETIF_F_GSO_UDP_TUNNEL;
+ }
next prev parent reply other threads:[~2013-12-22 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 15:26 [PATCH net-next V2 0/2] net/mlx4: Add support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 15:26 ` [PATCH net-next V2 1/2] net/mlx4_core: Add basic support for TCP/IP offloads under tunneling Or Gerlitz
2013-12-22 15:26 ` [PATCH net-next V2 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling Or Gerlitz
2013-12-22 23:12 ` David Miller
2013-12-22 23:32 ` Joe Perches [this message]
2013-12-23 0:14 ` David Miller
2013-12-23 1:02 ` [PATCH] checkpatch: Add warning with unnecessary parentheses in if statements Joe Perches
2013-12-23 10:54 ` [PATCH net-next V2 2/2] net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387755159.22671.27.camel@joe-AO722 \
--to=joe@perches.com \
--cc=amirv@mellanox.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).