* [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route
@ 2013-12-23 1:32 roy.qing.li
2013-12-23 1:49 ` RongQing Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: roy.qing.li @ 2013-12-23 1:32 UTC (permalink / raw)
To: netdev
From: Li RongQing <roy.qing.li@gmail.com>
Since addrconf_get_prefix_route inputs the address prefix to fib6_locate,
which does not uses the data which is out of the prefix_len length,
so do not need to use ipv6_addr_prefix to get address prefix.
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
net/ipv6/addrconf.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 3c3425e..def65f6 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -988,12 +988,9 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
* --yoshfuji
*/
if ((ifp->flags & IFA_F_PERMANENT) && onlink < 1) {
- struct in6_addr prefix;
struct rt6_info *rt;
- ipv6_addr_prefix(&prefix, &ifp->addr, ifp->prefix_len);
-
- rt = addrconf_get_prefix_route(&prefix,
+ rt = addrconf_get_prefix_route(&ifp->addr,
ifp->prefix_len,
ifp->idev->dev,
0, RTF_GATEWAY | RTF_DEFAULT);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route
2013-12-23 1:32 [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route roy.qing.li
@ 2013-12-23 1:49 ` RongQing Li
2013-12-23 12:37 ` Hannes Frederic Sowa
2013-12-31 18:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: RongQing Li @ 2013-12-23 1:49 UTC (permalink / raw)
To: netdev
On Mon, Dec 23, 2013 at 9:32 AM, <roy.qing.li@gmail.com> wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> Since addrconf_get_prefix_route inputs the address prefix to fib6_locate,
> which does not uses the data which is out of the prefix_len length,
> so do not need to use ipv6_addr_prefix to get address prefix.
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
> net/ipv6/addrconf.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
This should be for net-next, sorry.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route
2013-12-23 1:32 [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route roy.qing.li
2013-12-23 1:49 ` RongQing Li
@ 2013-12-23 12:37 ` Hannes Frederic Sowa
2013-12-31 18:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Frederic Sowa @ 2013-12-23 12:37 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
On Mon, Dec 23, 2013 at 09:32:38AM +0800, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> Since addrconf_get_prefix_route inputs the address prefix to fib6_locate,
> which does not uses the data which is out of the prefix_len length,
> so do not need to use ipv6_addr_prefix to get address prefix.
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
It was necessary before (a long time ago) but when switching to fib_locate* it
became unnecessary.
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route
2013-12-23 1:32 [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route roy.qing.li
2013-12-23 1:49 ` RongQing Li
2013-12-23 12:37 ` Hannes Frederic Sowa
@ 2013-12-31 18:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-12-31 18:38 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
From: roy.qing.li@gmail.com
Date: Mon, 23 Dec 2013 09:32:38 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> Since addrconf_get_prefix_route inputs the address prefix to fib6_locate,
> which does not uses the data which is out of the prefix_len length,
> so do not need to use ipv6_addr_prefix to get address prefix.
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-31 18:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 1:32 [PATCH] ipv6: unneccessary to get address prefix in addrconf_get_prefix_route roy.qing.li
2013-12-23 1:49 ` RongQing Li
2013-12-23 12:37 ` Hannes Frederic Sowa
2013-12-31 18:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).