netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v4 13/16] i40e: be more informative
Date: Fri, 27 Dec 2013 19:22:17 -0800	[thread overview]
Message-ID: <1388200940-9113-14-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1388200940-9113-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Mitch Williams <mitch.a.williams@intel.com>

If the VF sends a bad message, be more informative about what it
actually is.

Change-Id: I89e06d2db416a1d05aeea016dd6e8b7870cae99a
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 4386a2f..1dd13f4 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1653,7 +1653,8 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,
 	ret = i40e_vc_validate_vf_msg(vf, v_opcode, v_retval, msg, msglen);
 
 	if (ret) {
-		dev_err(&pf->pdev->dev, "invalid message from vf %d\n", vf_id);
+		dev_err(&pf->pdev->dev, "Invalid message from vf %d, opcode %d, len %d\n",
+			vf_id, v_opcode, msglen);
 		return ret;
 	}
 	wr32(hw, I40E_VFGEN_RSTAT1(vf_id), I40E_VFR_VFACTIVE);
-- 
1.8.3.1

  parent reply	other threads:[~2013-12-28  3:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-28  3:22 [net-next v4 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 01/16] i40e: using for_each_set_bit to simplify the code Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 02/16] i40e: Suppress HMC error to Interrupt message level Jeff Kirsher
2013-12-28  6:11   ` David Miller
2013-12-28  3:22 ` [net-next v4 03/16] i40e: Populate and check pci bus speed and width Jeff Kirsher
2013-12-28  6:10   ` David Miller
2013-12-28  3:22 ` [net-next v4 04/16] i40e: add wake-on-lan support Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 05/16] i40e: fix curly brace use and return type Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 06/16] i40e: Implementation of VXLAN ndo's Jeff Kirsher
2013-12-28  6:17   ` David Miller
2013-12-28  3:22 ` [net-next v4 07/16] i40e: Rx checksum offload for VXLAN Jeff Kirsher
2014-01-02 10:20   ` Or Gerlitz
2014-01-02 20:57     ` Joseph Gasparakis
2014-01-02 21:31       ` Or Gerlitz
2014-01-03 19:07         ` Joseph Gasparakis
2013-12-28  3:22 ` [net-next v4 08/16] i40e: move i40e_reset_vf Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 09/16] i40e: refactor VF reset flow Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 10/16] i40e: remove redundant code Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 11/16] i40e: remove chatty log messages Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 12/16] i40e: fix error return Jeff Kirsher
2013-12-28  3:22 ` Jeff Kirsher [this message]
2013-12-28  3:22 ` [net-next v4 14/16] i40e: make a define from a large constant Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 15/16] i40e: update led set args Jeff Kirsher
2013-12-28  3:22 ` [net-next v4 16/16] i40e: report VF MAC addresses correctly Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388200940-9113-14-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).