From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
vyasevich@gmail.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings
Date: Tue, 31 Dec 2013 12:08:14 -0800 [thread overview]
Message-ID: <1388520494.2259.27.camel@joe-AO722> (raw)
In-Reply-To: <20131231.140000.463004971089550957.davem@davemloft.net>
On Tue, 2013-12-31 at 14:00 -0500, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Mon, 23 Dec 2013 08:29:41 -0500
>
> > The SCTP protocol has several deprecation warnings in its setsockopt path that
> > can be triggered by unprivlidged users. Since these are not ratelimited, we can
> > spam the logs quite easily here. Since these are all deprecation warnings, and
> > that type of warning isn't uncommon in the rest of the kernel, lets make a
> > common pr_warn_deprecated macro to produce somewhat generalized ratelimited
> > deprecation warnings easily
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> Series applied, thanks Neil.
>
> Please consider Ben's suggestion to provide the offending command string
> in the log output.
If something like the printk extension described in this thread
http://thread.gmane.org/gmane.linux.kernel/1620126 is ever accepted,
then it should be pretty easy to add later.
next prev parent reply other threads:[~2013-12-31 20:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 14:44 [PATCH] SCTP: Reduce log spamming for sctp setsockopt Neil Horman
2013-12-16 15:03 ` Joe Perches
2013-12-16 15:13 ` Daniel Borkmann
2013-12-16 15:21 ` Joe Perches
2013-12-16 15:45 ` Daniel Borkmann
2013-12-16 16:04 ` Neil Horman
2013-12-16 16:50 ` Joe Perches
2013-12-16 17:02 ` Neil Horman
2013-12-16 17:17 ` Joe Perches
2013-12-16 17:04 ` Daniel Borkmann
2013-12-16 15:24 ` David Laight
2013-12-16 15:44 ` Neil Horman
2013-12-16 17:06 ` [PATCH v2 0/2] sctp: Consolidate and ratelimit deprecation warnings Neil Horman
2013-12-16 17:06 ` [PATCH v2 2/2] SCTP: Reduce log spamming for sctp setsockopt Neil Horman
2013-12-17 16:19 ` [PATCH v3 0/2] sctp: Consolidate and ratelimit deprecation warnings Neil Horman
2013-12-17 16:19 ` [PATCH v3 2/2] SCTP: Reduce log spamming for sctp setsockopt Neil Horman
2013-12-22 22:56 ` [PATCH v3 0/2] sctp: Consolidate and ratelimit deprecation warnings David Miller
2013-12-23 13:19 ` Neil Horman
2013-12-23 13:29 ` [PATCH v4 " Neil Horman
2013-12-23 13:29 ` [PATCH v4 1/2] printk: Add a DEPRECATED macro Neil Horman
2013-12-23 13:29 ` [PATCH v4 2/2] SCTP: Reduce log spamming for sctp setsockopt Neil Horman
2013-12-23 22:55 ` [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings Ben Hutchings
2013-12-24 13:37 ` Neil Horman
2013-12-31 19:00 ` David Miller
2013-12-31 20:08 ` Joe Perches [this message]
2014-01-02 14:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388520494.2259.27.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).