From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next] igb: cleanups
Date: Tue, 31 Dec 2013 16:59:16 -0800 [thread overview]
Message-ID: <1388537956.26537.8.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20131230103648.5ac53b4f@nehalam.linuxnetplumber.net>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On Mon, 2013-12-30 at 10:36 -0800, Stephen Hemminger wrote:
> This patch is against current version in net-next, some of this may
> not
> apply after other patches you have pending.
>
> Make local functions static.
>
> Delete unused code (igb_get_eee_status_i354,
> e1000_write_sfp_data_byte)
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
> ---
> drivers/net/ethernet/intel/igb/e1000_82575.c | 37 --------------
> drivers/net/ethernet/intel/igb/e1000_82575.h | 2
> drivers/net/ethernet/intel/igb/e1000_i210.c | 20 ++++---
> drivers/net/ethernet/intel/igb/e1000_i210.h | 9 ---
> drivers/net/ethernet/intel/igb/e1000_phy.c | 71
> ---------------------------
> drivers/net/ethernet/intel/igb/e1000_phy.h | 1
> drivers/net/ethernet/intel/igb/igb.h | 2
> drivers/net/ethernet/intel/igb/igb_ptp.c | 6 +-
> 8 files changed, 17 insertions(+), 131 deletions(-)
Thanks Stephen, I believe Carolyn already has a patch in the queue to
resolve all these, but just in case I add your patch to make sure that
all these get resolved or addressed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-01-01 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 18:36 [PATCH net-next] igb: cleanups Stephen Hemminger
2014-01-01 0:59 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388537956.26537.8.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).