From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <sd@queasysnail.net>, <johannes@sipsolutions.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 4/5] alx: add alx_get_stats operation
Date: Thu, 2 Jan 2014 11:56:53 +0000 [thread overview]
Message-ID: <1388663813.22017.12.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20140101.222702.1562824655053158808.davem@davemloft.net>
On Wed, 2014-01-01 at 22:27 -0500, David Miller wrote:
> From: Sabrina Dubroca <sd@queasysnail.net>
> Date: Thu, 2 Jan 2014 00:40:27 +0100
>
> > + spin_lock(&alx->stats_lock);
> > +
> > + __alx_update_hw_stats(&alx->hw);
>
> Please use something like the linux/u64_stats_sync.h stuff rather
> than spin locking.
I don't think that'sa useful, as we can have multiple writers
(concurrent calls to get_stats). And there is really no harm in using a
spinlock to serialise get_stats calls. The u64_stats API is good for
statistics updated from the data path.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2014-01-02 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 23:40 [PATCH 0/5] alx: add statistics Sabrina Dubroca
2014-01-01 23:40 ` [PATCH 1/5] alx: add a hardware stats structure Sabrina Dubroca
2014-01-02 11:52 ` Ben Hutchings
2014-01-01 23:40 ` [PATCH 2/5] alx: add constants for the stats fields Sabrina Dubroca
2014-01-01 23:40 ` [PATCH 3/5] alx: add stats update function Sabrina Dubroca
2014-01-02 5:55 ` Stephen Hemminger
2014-01-02 11:52 ` Ben Hutchings
2014-01-01 23:40 ` [PATCH 4/5] alx: add alx_get_stats operation Sabrina Dubroca
2014-01-02 3:27 ` David Miller
2014-01-02 11:56 ` Ben Hutchings [this message]
2014-01-02 16:05 ` Sabrina Dubroca
2014-01-02 16:25 ` Ben Hutchings
2014-01-02 17:39 ` David Miller
2014-01-02 11:57 ` Ben Hutchings
2014-01-01 23:40 ` [PATCH 5/5] alx: add stats to ethtool Sabrina Dubroca
2014-01-02 12:01 ` Ben Hutchings
2014-01-02 18:23 ` Ben Hutchings
2014-01-02 13:09 ` Johannes Berg
2014-01-02 18:19 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388663813.22017.12.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).