Re: [Patch] netxen_nic: Bugfix for wrong RUNNING status of NX3031 NICs with no link

[Ben Hutchings <bhutchings@solarflare.com>]

On Thu, 2014-01-02 at 11:37 +0800, jiang.biao2@zte.com.cn wrote:
> From: Li Fengmao <li.fengmao@zte.com.cn>
> 
> Ifconfig command displays RUNNING status when there is no link on
> NX3031 NICs. The problem is caused by the wrong calling order of
> netif_carrier_off() and register_netdev() in netxen_setup_netdev(),
> dev->reg_state is initialized to NETREG_UNINITIALIZED before
> registering network device, so the linkwatch_fire_event() will not
> be called to notify the link change event in netif_carrier_off(),
> and the operational status of network device will be set to
> IF_OPER_UNKNOWN. In that case, the IFF_RUNNING flags will be set,
> which result in the wrong RUNNING status in the result of ifconfig
> command.
[...]

This was fixed in Linux 3.7.  The driver should not be changed.

(This change may be worthwhile in an out-of-tree version for older
kernel versions, but beware of races with opening of the device.)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.