Re: [net-next v5 04/17] i40e: Populate and check pci bus speed and width

Jeff Kirsher
2014-01-05T05:12:51Z

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On Sat, 2014-01-04 at 19:49 -0500, David Miller wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> Date: Sat, 4 Jan 2014 14:04:30 -0700
>
> > I don't see anything device-specific here. This all looks to be
> > generic per the PCIe spec, without anything specific to the i40e. In
> > fact, this new code looks almost identical to what Jacob added to
> > ixgbe with e027d1aec4bb, except that Jacob's code checks the whole
> > path up to the root, not just the single link leading to the device.
> >
> > Since you're doing basically the same thing, it'd be nice if the code
> > looked basically the same.
>
> Agreed.
>
> I'm going to pull from Jeff's tree meanwhile and ask that this consolidation
> happens as follow-up changes.
>
> Thanks.

Agreed, I will work with Jesse to make sure those changes get into the
driver in a follow-on patch.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]