From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>, jesse.brandeburg@intel.com
Cc: bhelgaas@google.com, catherine.sullivan@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
jesse.brandeburg@intel.com, jacob.e.keller@intel.com
Subject: Re: [net-next v5 04/17] i40e: Populate and check pci bus speed and width
Date: Sat, 04 Jan 2014 21:12:38 -0800 [thread overview]
Message-ID: <1388898758.2987.1.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20140104.194942.638270130526105275.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Sat, 2014-01-04 at 19:49 -0500, David Miller wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> Date: Sat, 4 Jan 2014 14:04:30 -0700
>
> > I don't see anything device-specific here. This all looks to be
> > generic per the PCIe spec, without anything specific to the i40e. In
> > fact, this new code looks almost identical to what Jacob added to
> > ixgbe with e027d1aec4bb, except that Jacob's code checks the whole
> > path up to the root, not just the single link leading to the device.
> >
> > Since you're doing basically the same thing, it'd be nice if the code
> > looked basically the same.
>
> Agreed.
>
> I'm going to pull from Jeff's tree meanwhile and ask that this consolidation
> happens as follow-up changes.
>
> Thanks.
Agreed, I will work with Jesse to make sure those changes get into the
driver in a follow-on patch.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-01-05 5:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 5:56 [net-next v5 00/17][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 01/17] pci_regs.h: Add PCI bus link speed and width defines Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 02/17] i40e: using for_each_set_bit to simplify the code Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 03/17] i40e: Suppress HMC error to Interrupt message level Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 04/17] i40e: Populate and check pci bus speed and width Jeff Kirsher
2014-01-04 21:04 ` Bjorn Helgaas
2014-01-05 0:49 ` David Miller
2014-01-05 5:12 ` Jeff Kirsher [this message]
2014-01-04 5:56 ` [net-next v5 05/17] i40e: add wake-on-lan support Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 06/17] i40e: fix curly brace use and return type Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 07/17] i40e: Implementation of VXLAN ndo's Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 08/17] i40e: Rx checksum offload for VXLAN Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 09/17] i40e: move i40e_reset_vf Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 10/17] i40e: refactor VF reset flow Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 11/17] i40e: remove redundant code Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 12/17] i40e: remove chatty log messages Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 13/17] i40e: fix error return Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 14/17] i40e: be more informative Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 15/17] i40e: make a define from a large constant Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 16/17] i40e: update led set args Jeff Kirsher
2014-01-04 5:56 ` [net-next v5 17/17] i40e: report VF MAC addresses correctly Jeff Kirsher
2014-01-05 0:50 ` [net-next v5 00/17][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388898758.2987.1.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bhelgaas@google.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox