From: Joe Perches <joe@perches.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] r8152: replace the return value of rtl_ops_init
Date: Sun, 05 Jan 2014 22:59:22 -0800 [thread overview]
Message-ID: <1388991562.5808.39.camel@joe-AO722> (raw)
In-Reply-To: <1388990366-8508-4-git-send-email-hayeswang@realtek.com>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
[]
> @@ -2721,18 +2722,20 @@ static bool rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id)
[]
> + if (ret)
> + netif_err(tp, probe, tp->netdev, "Unknown Device");
This format should have a terminating newline
"Unknown Device\n"
next prev parent reply other threads:[~2014-01-06 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 6:39 [PATCH net-next 0/3] adjust the code of r8152 Hayes Wang
2014-01-06 6:39 ` [PATCH net-next 1/3] r8152: replace some tabs with spaces Hayes Wang
2014-01-06 6:39 ` [PATCH net-next 2/3] r8152: move the actions of saving the information of the device Hayes Wang
[not found] ` <1388990366-8508-1-git-send-email-hayeswang-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2014-01-06 6:39 ` [PATCH net-next 3/3] r8152: replace the return value of rtl_ops_init Hayes Wang
2014-01-06 6:59 ` Joe Perches [this message]
2014-01-06 9:08 ` [PATCH net-next v2 0/3] adjust the code of r8152 Hayes Wang
2014-01-06 9:08 ` [PATCH net-next v2 1/3] r8152: replace some tabs with spaces Hayes Wang
2014-01-06 9:08 ` [PATCH net-next v2 2/3] r8152: move the actions of saving the information of the device Hayes Wang
2014-01-06 9:08 ` [PATCH net-next v2 3/3] r8152: replace the return value of rtl_ops_init Hayes Wang
2014-01-06 21:15 ` [PATCH net-next v2 0/3] adjust the code of r8152 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388991562.5808.39.camel@joe-AO722 \
--to=joe@perches.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox