* [PATCH net-next] netfilter: nfnetlink_queue: fix compilation problem due missing header
@ 2014-01-06 16:34 Pablo Neira Ayuso
2014-01-06 16:52 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-01-06 16:34 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
In 08c0cad ("netfilter: nfnetlink_queue: enable UID/GID socket info
retrieval"), the header that defines TCP_TIME_WAIT.
net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid':
net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function)
net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
Hi David,
Please, put this patch into net-next. It seems this compilation problem is
depending on the .config selections as I didn't reproducible when testing the
patches.
Thanks!
net/netfilter/nfnetlink_queue_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index d3cf12b..ce20bd8 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -32,6 +32,7 @@
#include <net/netfilter/nf_queue.h>
#include <net/netns/generic.h>
#include <net/netfilter/nfnetlink_queue.h>
+#include <net/tcp_states.h>
#include <linux/atomic.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] netfilter: nfnetlink_queue: fix compilation problem due missing header
2014-01-06 16:34 [PATCH net-next] netfilter: nfnetlink_queue: fix compilation problem due missing header Pablo Neira Ayuso
@ 2014-01-06 16:52 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2014-01-06 16:52 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel, davem, netdev
On Mon, 2014-01-06 at 17:34 +0100, Pablo Neira Ayuso wrote:
> In 08c0cad ("netfilter: nfnetlink_queue: enable UID/GID socket info
> retrieval"), the header that defines TCP_TIME_WAIT.
>
> net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid':
> net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function)
> net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1
>
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
Tested-by: Eric Dumazet <edumazet@google.com>
Thanks Pablo !
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-06 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-06 16:34 [PATCH net-next] netfilter: nfnetlink_queue: fix compilation problem due missing header Pablo Neira Ayuso
2014-01-06 16:52 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).