* [PATCH 0/2] net/mlx4_core: clean up two functions
@ 2014-01-07 13:00 Paul Bolle
2014-01-13 19:13 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-01-07 13:00 UTC (permalink / raw)
To: Or Gerlitz, Jack Morgenstein, Rony Efraim, Hadar Hen Zion,
David S. Miller
Cc: netdev, linux-kernel
0) These two patches are very similar. They both clean up a function to
help GCC understand the codeflow. Both help silence a warning.
1) Compile tested only (on 32 bits x86). I do not have this hardware.
2) Please note that there's no MAINTAINERS entry for mlx4_core. (Neither
is there an entry for the MLX4 IB driver.) Shouldn't it be added?
Paul Bolle (2):
net/mlx4_core: clean up cq_res_start_move_to()
net/mlx4_core: clean up srq_res_start_move_to()
.../net/ethernet/mellanox/mlx4/resource_tracker.c | 96 ++++++++--------------
1 file changed, 35 insertions(+), 61 deletions(-)
--
1.8.4.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/2] net/mlx4_core: clean up two functions
2014-01-07 13:00 [PATCH 0/2] net/mlx4_core: clean up two functions Paul Bolle
@ 2014-01-13 19:13 ` David Miller
2014-01-13 19:34 ` Amir Vadai
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-01-13 19:13 UTC (permalink / raw)
To: pebolle; +Cc: ogerlitz, jackm, ronye, hadarh, netdev, linux-kernel
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 07 Jan 2014 14:00:22 +0100
> 0) These two patches are very similar. They both clean up a function to
> help GCC understand the codeflow. Both help silence a warning.
>
> 1) Compile tested only (on 32 bits x86). I do not have this hardware.
>
> 2) Please note that there's no MAINTAINERS entry for mlx4_core. (Neither
> is there an entry for the MLX4 IB driver.) Shouldn't it be added?
These patches have been rotting for a week. I know the mlx4 folks
said the SRIOV guy inside Mellanox will look at it, but this is taking
way too long.
This is absolutely unreasonable from Paul's perspective to have to wait
this long for a review of these relatively simple patches.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: net/mlx4_core: clean up two functions
2014-01-13 19:13 ` David Miller
@ 2014-01-13 19:34 ` Amir Vadai
0 siblings, 0 replies; 3+ messages in thread
From: Amir Vadai @ 2014-01-13 19:34 UTC (permalink / raw)
To: David Miller
Cc: pebolle, ogerlitz, jackm, ronye, hadarh, netdev, linux-kernel,
amirv
On 13/01/14 11:13 -0800, David Miller wrote:
> From: Paul Bolle <pebolle@tiscali.nl>
> Date: Tue, 07 Jan 2014 14:00:22 +0100
>
> > 0) These two patches are very similar. They both clean up a function to
> > help GCC understand the codeflow. Both help silence a warning.
> >
> > 1) Compile tested only (on 32 bits x86). I do not have this hardware.
> >
> > 2) Please note that there's no MAINTAINERS entry for mlx4_core. (Neither
> > is there an entry for the MLX4 IB driver.) Shouldn't it be added?
>
> These patches have been rotting for a week. I know the mlx4 folks
> said the SRIOV guy inside Mellanox will look at it, but this is taking
> way too long.
>
> This is absolutely unreasonable from Paul's perspective to have to wait
> this long for a review of these relatively simple patches.
You're absolutely right.
And yes, jack is very busy.
We will have a reply ready tomorrow morning.
Amir
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 13:00 [PATCH 0/2] net/mlx4_core: clean up two functions Paul Bolle
2014-01-13 19:13 ` David Miller
2014-01-13 19:34 ` Amir Vadai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox