From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Greg Rose <gregory.v.rose@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 03/15] i40e: Stop accepting any VLAN tag on VLAN 0 filter set
Date: Tue, 7 Jan 2014 22:07:24 -0800 [thread overview]
Message-ID: <1389161256-24599-4-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1389161256-24599-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Greg Rose <gregory.v.rose@intel.com>
When the 8021q driver is loaded it sets VLAN 0 filters on all devices.
This does not mean that any VLAN tagged packet should be accepted.
Instead accept only VLAN 0 tagged packets so that upper layers can
interpret the priority bits.
Change-Id: I17274a540b613749612ffe23a3aef2b8ee6ff6a4
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 5ddbd54..2a42470 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1509,11 +1509,6 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)
cpu_to_le16((u16)(f->vlan ==
I40E_VLAN_ANY ? 0 : f->vlan));
- /* vlan0 as wild card to allow packets from all vlans */
- if (f->vlan == I40E_VLAN_ANY ||
- (vsi->netdev && !(vsi->netdev->features &
- NETIF_F_HW_VLAN_CTAG_FILTER)))
- cmd_flags |= I40E_AQC_MACVLAN_DEL_IGNORE_VLAN;
cmd_flags |= I40E_AQC_MACVLAN_DEL_PERFECT_MATCH;
del_list[num_del].flags = cmd_flags;
num_del++;
@@ -1579,12 +1574,6 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)
add_list[num_add].queue_number = 0;
cmd_flags |= I40E_AQC_MACVLAN_ADD_PERFECT_MATCH;
-
- /* vlan0 as wild card to allow packets from all vlans */
- if (f->vlan == I40E_VLAN_ANY || (vsi->netdev &&
- !(vsi->netdev->features &
- NETIF_F_HW_VLAN_CTAG_FILTER)))
- cmd_flags |= I40E_AQC_MACVLAN_ADD_IGNORE_VLAN;
add_list[num_add].flags = cpu_to_le16(cmd_flags);
num_add++;
--
1.8.3.1
next prev parent reply other threads:[~2014-01-08 6:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 6:07 [net-next v2 00/15][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 01/15] i40e: Expose AQ debugfs hooks Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 02/15] i40e: Do not enable broadcast promiscuous by default Jeff Kirsher
2014-01-08 6:07 ` Jeff Kirsher [this message]
2014-01-08 6:07 ` [net-next v2 04/15] i40e: Allow VF to set already assigned MAC address Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 05/15] i40e: Bump version Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 06/15] i40e: Add code to wait for FW to complete in reset path Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 07/15] i40e: update firmware api to 1.1 Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 08/15] i40e: Reduce range of interrupt reg in reg test Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 09/15] i40e: move PF ID init from PF reset to SC init Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 10/15] i40e: check MAC type before any REG access Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 11/15] i40e: rework shadow ram read functions Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 12/15] i40e: whitespace paren and comment tweaks Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 13/15] i40e: Enable/Disable PF switch LB on SR-IOV configure changes Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 14/15] i40e: remove redundant AQ enable Jeff Kirsher
2014-01-08 6:07 ` [net-next v2 15/15] i40e: correctly setup ARQ descriptors Jeff Kirsher
2014-01-08 6:50 ` [net-next v2 00/15][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389161256-24599-4-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).