From: Sabrina Dubroca <sd@queasysnail.net>
To: davem@davemloft.net
Cc: bhutchings@solarflare.com, johannes@sipsolutions.net,
stephen@networkplumber.org, netdev@vger.kernel.org,
Sabrina Dubroca <sd@queasysnail.net>
Subject: [PATCH v4 0/5] alx: add statistics
Date: Thu, 9 Jan 2014 10:09:26 +0100 [thread overview]
Message-ID: <1389258571-10083-1-git-send-email-sd@queasysnail.net> (raw)
Currently, the alx driver doesn't support statistics [1,2]. The
original alx driver [3] that Johannes Berg modified provided
statistics. This patch is an adaptation of the statistics code from
the original driver to the alx driver included in the kernel.
v4:
- modified the assignements of hw stats to netstats (Ben Hutchings)
- added comments to describe the stats fields (copied from atlx)
v3:
- renamed __alx_update_hw_stats to alx_update_hw_stats (Stephen Hemminger)
v2:
- use u64 instead of unsigned long (Ben Hutchings)
- implement ndo_get_stats64 instead of ndo_get_stats (Ben Hutchings)
- use EINVAL instead of ENOTSUPP (Ben Hutchings)
- add BUILD_BUG_ON to check the size of the stats (Johannes Berg, Ben
Hutchings)
- add a comment regarding persistence of the stats (Stephen Hemminger)
- align assignments in __alx_update_hw_stats
[1] https://bugzilla.kernel.org/show_bug.cgi?id=63401
[2] http://www.spinics.net/lists/netdev/msg245544.html
[3] https://github.com/mcgrof/alx
Sabrina Dubroca (5):
alx: add a hardware stats structure
alx: add constants for the stats fields
alx: add stats update function
alx: add alx_get_stats64 operation
alx: add stats to ethtool
drivers/net/ethernet/atheros/alx/alx.h | 3 +
drivers/net/ethernet/atheros/alx/ethtool.c | 101 +++++++++++++++++++++++++++++
drivers/net/ethernet/atheros/alx/hw.c | 58 +++++++++++++++++
drivers/net/ethernet/atheros/alx/hw.h | 71 ++++++++++++++++++++
drivers/net/ethernet/atheros/alx/main.c | 50 ++++++++++++++
drivers/net/ethernet/atheros/alx/reg.h | 52 +++++++++++++--
6 files changed, 331 insertions(+), 4 deletions(-)
--
1.8.5.2
next reply other threads:[~2014-01-09 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 9:09 Sabrina Dubroca [this message]
2014-01-09 9:09 ` [PATCH v4 1/5] alx: add a hardware stats structure Sabrina Dubroca
2014-01-09 9:09 ` [PATCH v4 2/5] alx: add constants for the stats fields Sabrina Dubroca
2014-01-09 9:09 ` [PATCH v4 3/5] alx: add stats update function Sabrina Dubroca
2014-01-09 9:09 ` [PATCH v4 4/5] alx: add alx_get_stats64 operation Sabrina Dubroca
2014-01-09 18:47 ` Ben Hutchings
2014-01-09 9:09 ` [PATCH v4 5/5] alx: add stats to ethtool Sabrina Dubroca
2014-01-12 4:54 ` [PATCH v4 0/5] alx: add statistics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389258571-10083-1-git-send-email-sd@queasysnail.net \
--to=sd@queasysnail.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox