From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Mitch Williams <mitch.a.williams@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next 05/16] i40e: fix long lines
Date: Fri, 10 Jan 2014 02:35:38 -0800 [thread overview]
Message-ID: <1389350138.2537.3.camel@joe-AO722> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D457950@AcuExch.aculab.com>
On Fri, 2014-01-10 at 10:02 +0000, David Laight wrote:
> > Another way this could be changed is to put the
> > return value on a separate line like:
> >
> > i40e_status
> > i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw, u16 seid, bool set,
> > struct i40e_asq_cmd_details *cmd_details)
>
> Personally I prefer that so I can find the definition by grepping
> for '^function_name' - but it doesn't seem to be done in any linux
> source files.
That form is used in a lot of files.
$ git grep -E "^[a-z_]+\("
next prev parent reply other threads:[~2014-01-10 10:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 8:58 [net-next 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-10 8:58 ` [net-next 01/16] i40e: use assignment instead of memcpy Jeff Kirsher
2014-01-10 8:58 ` [net-next 02/16] i40e: drop unused macros Jeff Kirsher
2014-01-10 8:58 ` [net-next 03/16] i40e: Update the Current NVM version Low value Jeff Kirsher
2014-01-10 8:58 ` [net-next 04/16] i40e: Bump version Jeff Kirsher
2014-01-10 8:58 ` [net-next 05/16] i40e: fix long lines Jeff Kirsher
2014-01-10 9:07 ` Joe Perches
2014-01-10 10:02 ` David Laight
2014-01-10 10:35 ` Joe Perches [this message]
2014-01-10 18:05 ` Williams, Mitch A
2014-01-10 18:14 ` Joe Perches
2014-01-10 18:20 ` Williams, Mitch A
2014-01-10 8:58 ` [net-next 06/16] i40e: Cleanup Doxygen warnings Jeff Kirsher
2014-01-10 8:58 ` [net-next 07/16] i40e: Setting queue count to 1 using ethtool is valid Jeff Kirsher
2014-01-10 8:58 ` [net-next 08/16] i40e: do not bail when disabling if Tx queue disable fails Jeff Kirsher
2014-01-10 8:58 ` [net-next 09/16] i40e: allow VF to remove any MAC filter Jeff Kirsher
2014-01-10 8:58 ` [net-next 10/16] i40e: check for possible incorrect ipv6 checksum Jeff Kirsher
2014-01-10 8:58 ` [net-next 11/16] i40e: adjust ITR max and min values Jeff Kirsher
2014-01-10 8:58 ` [net-next 12/16] i40e: clear qtx_head before enabling Tx queue Jeff Kirsher
2014-01-10 8:58 ` [net-next 13/16] i40e: call clear_pxe after adminq is initialized Jeff Kirsher
2014-01-10 8:58 ` [net-next 14/16] i40e: enable PTP Jeff Kirsher
2014-01-10 11:26 ` Richard Cochran
2014-01-10 15:55 ` Ben Hutchings
2014-01-10 16:48 ` Keller, Jacob E
2014-01-10 8:58 ` [net-next 15/16] i40e: fix log message wording Jeff Kirsher
2014-01-10 8:58 ` [net-next 16/16] i40e: Bump version Jeff Kirsher
2014-01-10 17:48 ` [net-next 00/16][pull request] Intel Wired LAN Driver Updates David Miller
2014-01-10 17:56 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389350138.2537.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox