From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [net-next 05/16] i40e: fix long lines Date: Fri, 10 Jan 2014 10:14:53 -0800 Message-ID: <1389377693.2537.39.camel@joe-AO722> References: <1389344336-1558-1-git-send-email-jeffrey.t.kirsher@intel.com> <1389344336-1558-6-git-send-email-jeffrey.t.kirsher@intel.com> <1389344869.24222.31.camel@joe-AO722> <063D6719AE5E284EB5DD2968C1650D6D457950@AcuExch.aculab.com> <1389350138.2537.3.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: David Laight , "Kirsher, Jeffrey T" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "gospo@redhat.com" , "sassmann@redhat.com" , "Brandeburg, Jesse" To: "Williams, Mitch A" Return-path: Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:45582 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750962AbaAJSO6 (ORCPT ); Fri, 10 Jan 2014 13:14:58 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2014-01-10 at 18:05 +0000, Williams, Mitch A wrote: > > -----Original Message----- > > From: Joe Perches [mailto:joe@perches.com] > > Sent: Friday, January 10, 2014 2:36 AM [] > > On Fri, 2014-01-10 at 10:02 +0000, David Laight wrote: > > > > Another way this could be changed is to put the > > > > return value on a separate line like: > > > > > > > > i40e_status > > > > i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw, u16 seid, bool > > set, > > > > struct i40e_asq_cmd_details *cmd_details) > > > > > > Personally I prefer that so I can find the definition by grepping > > > for '^function_name' - but it doesn't seem to be done in any linux > > > source files. > > > > That form is used in a lot of files. > > $ git grep -E "^[a-z_]+\(" > > > > So, Joe, I just want to be clear. Is this a NAK, or just an FYI? Hi Mitch. This is your/intel's code. I don't/shouldn't nak it. I made a simple suggestion of an alternate style. > If it's a serious issue for you (or Dave), we'll fix it right away. It's up to you all to fix it (or not) as you chose. It's trivial to me. cheers, Joe