From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v3 01/17] i40e: use assignment instead of memcpy
Date: Fri, 10 Jan 2014 16:47:14 -0800 [thread overview]
Message-ID: <1389401250-11509-2-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1389401250-11509-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
These instances were found by coccinelle/spatch, and can
use struct assignment instead of memcpy.
Change-ID: Idc23c3599241bf8a658bda18c80417af3fbfee66
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_common.c | 3 +--
drivers/net/ethernet/intel/i40e/i40e_hmc.c | 8 +++-----
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
index c75aa2d..4e5a02c 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
@@ -922,7 +922,7 @@ i40e_status i40e_clean_arq_element(struct i40e_hw *hw,
"AQRX: Event received with error 0x%X.\n",
hw->aq.arq_last_status);
} else {
- memcpy(&e->desc, desc, sizeof(struct i40e_aq_desc));
+ e->desc = *desc;
datalen = le16_to_cpu(desc->datalen);
e->msg_size = min(datalen, e->msg_size);
if (e->msg_buf != NULL && (e->msg_size != 0))
diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index 807312b..6bfbeec 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -599,8 +599,7 @@ i40e_status i40e_aq_get_link_info(struct i40e_hw *hw,
goto aq_get_link_info_exit;
/* save off old link status information */
- memcpy(&hw->phy.link_info_old, hw_link_info,
- sizeof(struct i40e_link_status));
+ hw->phy.link_info_old = *hw_link_info;
/* update link status */
hw_link_info->phy_type = (enum i40e_aq_phy_type)resp->phy_type;
diff --git a/drivers/net/ethernet/intel/i40e/i40e_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
index 76dfef3..bf2d4cc 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_hmc.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_hmc.c
@@ -89,11 +89,9 @@ i40e_status i40e_add_sd_table_entry(struct i40e_hw *hw,
sd_entry->u.pd_table.pd_entry =
(struct i40e_hmc_pd_entry *)
sd_entry->u.pd_table.pd_entry_virt_mem.va;
- memcpy(&sd_entry->u.pd_table.pd_page_addr, &mem,
- sizeof(struct i40e_dma_mem));
+ sd_entry->u.pd_table.pd_page_addr = mem;
} else {
- memcpy(&sd_entry->u.bp.addr, &mem,
- sizeof(struct i40e_dma_mem));
+ sd_entry->u.bp.addr = mem;
sd_entry->u.bp.sd_pd_index = sd_index;
}
/* initialize the sd entry */
@@ -164,7 +162,7 @@ i40e_status i40e_add_pd_table_entry(struct i40e_hw *hw,
if (ret_code)
goto exit;
- memcpy(&pd_entry->bp.addr, &mem, sizeof(struct i40e_dma_mem));
+ pd_entry->bp.addr = mem;
pd_entry->bp.sd_pd_index = pd_index;
pd_entry->bp.entry_type = I40E_SD_TYPE_PAGED;
/* Set page address and valid bit */
--
1.8.3.1
next prev parent reply other threads:[~2014-01-11 0:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 0:47 [net-next v3 00/17][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-01-11 0:47 ` Jeff Kirsher [this message]
2014-01-11 0:47 ` [net-next v3 02/17] i40e: drop unused macros Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 03/17] i40e: Update the Current NVM version Low value Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 04/17] i40e: Bump version Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 05/17] i40e: fix long lines Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 06/17] i40e: Cleanup Doxygen warnings Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 07/17] i40e: Setting queue count to 1 using ethtool is valid Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 08/17] i40e: do not bail when disabling if Tx queue disable fails Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 09/17] i40e: allow VF to remove any MAC filter Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 10/17] i40e: check for possible incorrect ipv6 checksum Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 11/17] i40e: adjust ITR max and min values Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 12/17] i40e: clear qtx_head before enabling Tx queue Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 13/17] i40e: call clear_pxe after adminq is initialized Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 14/17] i40e: enable PTP Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 15/17] i40e: fix log message wording Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 16/17] i40e: Bump version Jeff Kirsher
2014-01-11 0:47 ` [net-next v3 17/17] i40evf: fix s390 build failure due to implicit prefetch.h Jeff Kirsher
2014-01-12 4:51 ` [net-next v3 00/17][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389401250-11509-2-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox