Netdev List
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
	jcliburn@gmail.com, chris.snook@gmail.com,
	Sabrina Dubroca <sd@queasysnail.net>
Subject: [PATCH v2 0/3] atheros: modify statistics code
Date: Sun, 12 Jan 2014 18:50:37 +0100	[thread overview]
Message-ID: <1389549040-8785-1-git-send-email-sd@queasysnail.net> (raw)

Following Ben Hutchings's advice on how to fill net_stats in alx [1],
this patch modifies the other atheros ethernet drivers
similarly. Minor whitespace/empty line changes in atl1c and atl1e to
make the code completely consistent between atl1c, atl1e, and alx.

I don't have this hardware, so these patches have only been
compile-tested.


v2 (changes only in atl1):
 - don't set soft_stats.rx_missed_errors (Ben)
 - add errors to soft_stats.{rx,tx}_packets (Ben)
 - add soft_stats.rx_dropped field and update soft_stats.rx_dropped
   instead of netdev->stats (overwritten) outside of the stats
   update function

Detail of the changes (v1):
* atl1/atl1c/atl1e
  - fix collisions computation
  - rx_dropped = rx_rrd_ov
  - rx_over_errors = 0
  - rx_missed_errors = 0
  - X_packets = X_ok + X_errors

* only atl1c/atl1e
  - add rx_rxf_ov to rx_errors


[1] http://www.spinics.net/lists/netdev/msg264930.html


Sabrina Dubroca (3):
  atl1c: update statistics code
  atl1e: update statistics code
  atl1:  update statistics code

 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 31 +++++++++++-------
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 30 ++++++++++-------
 drivers/net/ethernet/atheros/atlx/atl1.c        | 43 ++++++++++++++-----------
 drivers/net/ethernet/atheros/atlx/atl1.h        |  1 +
 4 files changed, 65 insertions(+), 40 deletions(-)

-- 
1.8.5.2

             reply	other threads:[~2014-01-12 17:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 17:50 Sabrina Dubroca [this message]
2014-01-12 17:50 ` [PATCH v2 1/3] atl1c: update statistics code Sabrina Dubroca
2014-01-12 17:50 ` [PATCH v2 2/3] atl1e: " Sabrina Dubroca
2014-01-12 17:50 ` [PATCH v2 3/3] atl1: " Sabrina Dubroca
2014-01-15  1:18 ` [PATCH v2 0/3] atheros: modify " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389549040-8785-1-git-send-email-sd@queasysnail.net \
    --to=sd@queasysnail.net \
    --cc=bhutchings@solarflare.com \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jcliburn@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox