From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: [PATCH] xprtrdma: silence frame size warning Date: Mon, 13 Jan 2014 16:45:55 +0100 Message-ID: <1389627955.20467.9.camel@x41> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Trond Myklebust , "J. Bruce Fields" , "David S. Miller" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Building verbs.o on 32 bits x86, with CONFIG_FRAME_WARN set to 1024, it= s default value, triggers this GCC warning: net/sunrpc/xprtrdma/verbs.c: In function =E2=80=98rpcrdma_register_= default_external=E2=80=99: net/sunrpc/xprtrdma/verbs.c:1774:1: warning: the frame size of 1040= bytes is larger than 1024 bytes [-Wframe-larger-than=3D] Silence this warning by allocating "ipb" dynamically. Signed-off-by: Paul Bolle --- 0) Compile tested only (on 32 bits x86). I don't have access to Infiniband hardware. 1) Please note that this is not a new warning. The oldest build log I have still available on this machine is for a v3.8 rc, and it already showed this warning.=20 2) I do hope my choice for the GFP_KERNEL flag is correct here. net/sunrpc/xprtrdma/verbs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 93726560..939ccc8 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1736,11 +1736,14 @@ rpcrdma_register_default_external(struct rpcrdm= a_mr_seg *seg, int mem_priv =3D (writing ? IB_ACCESS_REMOTE_WRITE : IB_ACCESS_REMOTE_READ); struct rpcrdma_mr_seg *seg1 =3D seg; - struct ib_phys_buf ipb[RPCRDMA_MAX_DATA_SEGS]; + struct ib_phys_buf *ipb; int len, i, rc =3D 0; =20 if (*nsegs > RPCRDMA_MAX_DATA_SEGS) *nsegs =3D RPCRDMA_MAX_DATA_SEGS; + ipb =3D kmalloc(sizeof(*ipb) * *nsegs, GFP_KERNEL); + if (ipb =3D=3D NULL) + return -ENOMEM; for (len =3D 0, i =3D 0; i < *nsegs;) { rpcrdma_map_one(ia, seg, writing); ipb[i].addr =3D seg->mr_dma; @@ -1770,6 +1773,7 @@ rpcrdma_register_default_external(struct rpcrdma_= mr_seg *seg, seg1->mr_len =3D len; } *nsegs =3D i; + kfree(ipb); return rc; } =20 --=20 1.8.4.2