* [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET
@ 2014-01-13 18:01 Paul Gortmaker
2014-01-14 11:35 ` Patrick McHardy
0 siblings, 1 reply; 4+ messages in thread
From: Paul Gortmaker @ 2014-01-13 18:01 UTC (permalink / raw)
To: David S. Miller, Pablo Neira Ayuso, Patrick McHardy,
Jozsef Kadlecsik
Cc: netfilter, netdev, Paul Gortmaker
Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables:
add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled
.config files that will fail to configure/link as follows:
warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
net/built-in.o: In function `nft_reject_eval':
nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum'
nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output'
nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit'
make: *** [vmlinux] Error 1
Since the feature is to allow for a mixed IPV4 and IPV6 table, it
seems sensible to make it depend on IPV6.
Cc: Patrick McHardy <kaber@trash.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index afe50c0f526f..c37467562fd0 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -429,7 +429,7 @@ config NF_TABLES
To compile it as a module, choose M here.
config NF_TABLES_INET
- depends on NF_TABLES
+ depends on NF_TABLES && IPV6
select NF_TABLES_IPV4
select NF_TABLES_IPV6
tristate "Netfilter nf_tables mixed IPv4/IPv6 tables support"
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET
2014-01-13 18:01 [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET Paul Gortmaker
@ 2014-01-14 11:35 ` Patrick McHardy
2014-01-14 15:34 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Patrick McHardy @ 2014-01-14 11:35 UTC (permalink / raw)
To: Paul Gortmaker, David S. Miller, Pablo Neira Ayuso,
Jozsef Kadlecsik
Cc: netfilter, netdev
Paul Gortmaker <paul.gortmaker@windriver.com> schrieb:
>Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables:
>add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled
>.config files that will fail to configure/link as follows:
>
>warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>net/built-in.o: In function `nft_reject_eval':
>nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum'
>nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output'
>nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit'
>make: *** [vmlinux] Error 1
>
>Since the feature is to allow for a mixed IPV4 and IPV6 table, it
>seems sensible to make it depend on IPV6.
Acked-by: Patrick McHardy <kaber@trash.net>
>
>Cc: Patrick McHardy <kaber@trash.net>
>Cc: Pablo Neira Ayuso <pablo@netfilter.org>
>Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
>diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
>index afe50c0f526f..c37467562fd0 100644
>--- a/net/netfilter/Kconfig
>+++ b/net/netfilter/Kconfig
>@@ -429,7 +429,7 @@ config NF_TABLES
> To compile it as a module, choose M here.
>
> config NF_TABLES_INET
>- depends on NF_TABLES
>+ depends on NF_TABLES && IPV6
> select NF_TABLES_IPV4
> select NF_TABLES_IPV6
> tristate "Netfilter nf_tables mixed IPv4/IPv6 tables support"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET
2014-01-14 11:35 ` Patrick McHardy
@ 2014-01-14 15:34 ` Pablo Neira Ayuso
2014-01-14 15:49 ` Paul Gortmaker
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2014-01-14 15:34 UTC (permalink / raw)
To: Patrick McHardy
Cc: Paul Gortmaker, David S. Miller, Jozsef Kadlecsik, netfilter,
netdev, netfilter-devel
On Tue, Jan 14, 2014 at 11:35:42AM +0000, Patrick McHardy wrote:
> Paul Gortmaker <paul.gortmaker@windriver.com> schrieb:
> >Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables:
> >add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled
> >.config files that will fail to configure/link as follows:
> >
> >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
> >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
> >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
> >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
> >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
> >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
> >net/built-in.o: In function `nft_reject_eval':
> >nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum'
> >nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output'
> >nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit'
> >make: *** [vmlinux] Error 1
> >
> >Since the feature is to allow for a mixed IPV4 and IPV6 table, it
> >seems sensible to make it depend on IPV6.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks.
@Paul: Please, use netfilter-devel ML instead next time. The netfilter
ML is reserved for user questions only. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET
2014-01-14 15:34 ` Pablo Neira Ayuso
@ 2014-01-14 15:49 ` Paul Gortmaker
0 siblings, 0 replies; 4+ messages in thread
From: Paul Gortmaker @ 2014-01-14 15:49 UTC (permalink / raw)
To: Pablo Neira Ayuso, Patrick McHardy
Cc: David S. Miller, Jozsef Kadlecsik, netfilter, netdev,
netfilter-devel
On 14-01-14 10:34 AM, Pablo Neira Ayuso wrote:
> On Tue, Jan 14, 2014 at 11:35:42AM +0000, Patrick McHardy wrote:
>> Paul Gortmaker <paul.gortmaker@windriver.com> schrieb:
>>> Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables:
>>> add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled
>>> .config files that will fail to configure/link as follows:
>>>
>>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct
>>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES)
>>> net/built-in.o: In function `nft_reject_eval':
>>> nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum'
>>> nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output'
>>> nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit'
>>> make: *** [vmlinux] Error 1
>>>
>>> Since the feature is to allow for a mixed IPV4 and IPV6 table, it
>>> seems sensible to make it depend on IPV6.
>>
>> Acked-by: Patrick McHardy <kaber@trash.net>
>
> Applied, thanks.
>
> @Paul: Please, use netfilter-devel ML instead next time. The netfilter
> ML is reserved for user questions only. Thanks.
Sure, I can do that. But it would probably be better if
get_maintainer.pl didn't emit that particular address then.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-14 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-13 18:01 [PATCH] netfilter: Add dependency on IPV6 for NF_TABLES_INET Paul Gortmaker
2014-01-14 11:35 ` Patrick McHardy
2014-01-14 15:34 ` Pablo Neira Ayuso
2014-01-14 15:49 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).