From: Joe Perches <joe@perches.com>
To: Aaron Brown <aaron.f.brown@intel.com>
Cc: davem@davemloft.net, Mark Rustad <mark.d.rustad@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next v4 3/7] ixgbe: Use static inlines instead of macros
Date: Tue, 14 Jan 2014 19:17:19 -0800 [thread overview]
Message-ID: <1389755839.14001.6.camel@joe-AO722> (raw)
In-Reply-To: <1389754397-2507-4-git-send-email-aaron.f.brown@intel.com>
On Tue, 2014-01-14 at 18:53 -0800, Aaron Brown wrote:
> From: Mark Rustad <mark.d.rustad@intel.com>
trivia:
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h
[]
> @@ -124,24 +124,40 @@ s32 ixgbe_reset_pipeline_82599(struct ixgbe_hw *hw);
[]
> -#define IXGBE_WRITE_REG(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
> +static inline void ixgbe_write_reg(struct ixgbe_hw *hw, u32 reg, u32 value)
> +{
> + writel(value, hw->hw_addr + reg);
> +}
> +#define IXGBE_WRITE_REG(a, reg, value) ixgbe_write_reg((a), (reg), (value))
There's no real value in adding parentheses to these macros.
next prev parent reply other threads:[~2014-01-15 3:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 2:53 [net-next v4 0/7] Intel Wired LAN Driver Updates, ixgbe: Add LER support Aaron Brown
2014-01-15 2:53 ` [net-next v4 1/7] ixgbe: Indicate removal state explicitly Aaron Brown
2014-01-15 2:53 ` [net-next v4 2/7] ixbge: Protect ixgbe_down with __IXGBE_DOWN bit Aaron Brown
2014-01-15 2:53 ` [net-next v4 3/7] ixgbe: Use static inlines instead of macros Aaron Brown
2014-01-15 3:17 ` Joe Perches [this message]
2014-01-15 16:16 ` Rustad, Mark D
2014-01-15 2:53 ` [net-next v4 4/7] ixgbe: Make ethtool register test use accessors Aaron Brown
2014-01-15 2:53 ` [net-next v4 5/7] ixgbe: Check register reads for adapter removal Aaron Brown
2014-01-15 2:53 ` [net-next v4 6/7] ixgbe: Check for adapter removal on register writes Aaron Brown
2014-01-15 2:53 ` [net-next v4 7/7] ixgbe: Additional adapter removal checks Aaron Brown
2014-01-15 2:59 ` [net-next v4 0/7] Intel Wired LAN Driver Updates, ixgbe: Add LER support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389755839.14001.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=aaron.f.brown@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=mark.d.rustad@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox