From: Aaron Brown <aaron.f.brown@intel.com>
To: davem@davemloft.net
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Catherine Sullivan <catherine.sullivan@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>
Subject: [net-next 2/9] i40e: Change firmware workaround
Date: Fri, 17 Jan 2014 15:36:32 -0800 [thread overview]
Message-ID: <1390001799-19425-3-git-send-email-aaron.f.brown@intel.com> (raw)
In-Reply-To: <1390001799-19425-1-git-send-email-aaron.f.brown@intel.com>
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
Remove a workaround that is no longer necessary and implement
a better understanding of what firmware is returning in the MSI-X
vector count. This makes it so that the driver ends up with the
right amount of queues when using all available MSI-X vectors.
Change-ID: I34e60cc71dcfb1b5412f37df956fedcc49ade187
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e.h | 1 -
drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++------
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
index dff4447..6d0a702 100644
--- a/drivers/net/ethernet/intel/i40e/i40e.h
+++ b/drivers/net/ethernet/intel/i40e/i40e.h
@@ -63,7 +63,6 @@
#define I40E_BASE_VSI_SEID 512
#define I40E_BASE_VEB_SEID 288
#define I40E_MAX_VEB 16
-#define I40E_MAX_NPAR_QPS 32
#define I40E_MAX_NUM_DESCRIPTORS 4096
#define I40E_MAX_REGISTER 0x800000
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 7bfa789..ff4aa74 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4704,12 +4704,8 @@ static int i40e_get_capabilities(struct i40e_pf *pf)
}
} while (err);
- if (pf->hw.revision_id == 0 && (pf->flags & I40E_FLAG_MFP_ENABLED)) {
- pf->hw.func_caps.num_msix_vectors += 1;
- pf->hw.func_caps.num_tx_qp =
- min_t(int, pf->hw.func_caps.num_tx_qp,
- I40E_MAX_NPAR_QPS);
- }
+ /* increment MSI-X count because current FW skips one */
+ pf->hw.func_caps.num_msix_vectors++;
if (pf->hw.debug_mask & I40E_DEBUG_USER)
dev_info(&pf->pdev->dev,
--
1.8.5.GIT
next prev parent reply other threads:[~2014-01-17 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 23:36 [net-next 0/9] Intel Wired LAN Driver Updates Aaron Brown
2014-01-17 23:36 ` [net-next 1/9] i40e: fix compile warning on checksum_local Aaron Brown
2014-01-17 23:36 ` Aaron Brown [this message]
2014-01-17 23:36 ` [net-next 3/9] i40e: whitespace fixes Aaron Brown
2014-01-17 23:36 ` [net-next 4/9] i40e: rename defines Aaron Brown
2014-01-17 23:36 ` [net-next 5/9] i40e: refactor flow director Aaron Brown
2014-01-17 23:36 ` [net-next 6/9] i40e: implement DCB support infastructure Aaron Brown
2014-01-17 23:36 ` [net-next 7/9] i40e: add DCB and DCBNL support Aaron Brown
2014-01-17 23:36 ` [net-next 8/9] i40e: add DCB option to Kconfig Aaron Brown
2014-01-17 23:36 ` [net-next 9/9] i40e: Fix device ID define names to align to standard Aaron Brown
2014-01-18 3:17 ` [net-next 0/9] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390001799-19425-3-git-send-email-aaron.f.brown@intel.com \
--to=aaron.f.brown@intel.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).