From: Florian Fainelli <f.fainelli@gmail.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <joe@perches.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next v2 4/4] net: phy: remove unneeded parenthesis
Date: Thu, 23 Jan 2014 12:17:49 -0800 [thread overview]
Message-ID: <1390508269-28769-5-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1390508269-28769-1-git-send-email-f.fainelli@gmail.com>
Our if/else statement in phy_print_status() is only comprised of one
line for each, remove the parenthesis.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/phy.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 36fc6e1..59aa85e 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -64,15 +64,14 @@ static const char *phy_speed_to_str(int speed)
*/
void phy_print_status(struct phy_device *phydev)
{
- if (phydev->link) {
+ if (phydev->link)
netdev_info(phydev->attached_dev,
"Link is Up - %s/%s - flow control %s\n",
phy_speed_to_str(phydev->speed),
DUPLEX_FULL == phydev->duplex ? "Full" : "Half",
phydev->pause ? "rx/tx" : "off");
- } else {
+ else
netdev_info(phydev->attached_dev, "Link is Down\n");
- }
}
EXPORT_SYMBOL(phy_print_status);
--
1.8.3.2
next prev parent reply other threads:[~2014-01-23 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 20:17 [PATCH net-next v2 0/4] net: phy: neaten phy_print_status Florian Fainelli
2014-01-23 20:17 ` [PATCH net-next v2 1/4] net: phy: use network device in phy_print_status Florian Fainelli
2014-01-23 20:17 ` [PATCH net-next v2 2/4] net: phy: update phy_print_status to show pause settings Florian Fainelli
2014-01-23 20:17 ` [PATCH net-next v2 3/4] net: phy: display human readable PHY speed settings Florian Fainelli
2014-01-23 20:17 ` Florian Fainelli [this message]
2014-01-23 22:37 ` [PATCH net-next v2 4/4] net: phy: remove unneeded parenthesis Sergei Shtylyov
2014-01-23 22:39 ` Florian Fainelli
2014-01-23 22:59 ` Sergei Shtylyov
2014-01-23 23:39 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390508269-28769-5-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).