From: "François-Xavier Le Bail" <fx.lebail@yahoo.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>,
Linux Netdev List <netdev@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH] iproute: Properly handle protocol level diag module absence
Date: Wed, 29 Jan 2014 11:39:51 -0800 (PST) [thread overview]
Message-ID: <1391024391.38232.YahooMailBasic@web125506.mail.ne1.yahoo.com> (raw)
In-Reply-To: <52E7E990.7050501@parallels.com>
On Tue, 1/28/14, Pavel Emelyanov <xemul@parallels.com> wrote:
> When *_diag module is missing in the kernel, the ss tool should go
> ad read legacry /proc/* files.
> This is the case when all *_diag stuff is missing, but in case the
> inet_diag.ko is loaded, but (tcp|udp)_diag.ko is not, the ss tool
> doesn't notice this and produces empty output. The reason for that
> is -- error from the inet_diag module (which means, that e.g. the
> udp_diag is missing) is reported in the NLMSG_DONE message body.
> That said, we need to check the NLMSG_DONE's message return code
> and act respectively.
> Reported-by: François-Xavier Le Bail <fx.lebail@yahoo.com>
> Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
> ---
Tested-by: François-Xavier Le Bail <fx.lebail@yahoo.com>
next prev parent reply other threads:[~2014-01-29 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 17:32 [PATCH] iproute: Properly handle protocol level diag module absence Pavel Emelyanov
2014-01-29 19:39 ` François-Xavier Le Bail [this message]
2014-02-10 22:37 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391024391.38232.YahooMailBasic@web125506.mail.ne1.yahoo.com \
--to=fx.lebail@yahoo.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).