From: Joe Perches <joe@perches.com>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: Zoran Markovic <zoran.markovic@linaro.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: core: move core networking work to power efficient workqueue
Date: Thu, 30 Jan 2014 16:55:01 -0800 [thread overview]
Message-ID: <1391129701.2422.75.camel@joe-AO722> (raw)
In-Reply-To: <52EAF2E5.8090403@meshcoding.com>
On Fri, 2014-01-31 at 01:48 +0100, Antonio Quartulli wrote:
> On 31/01/14 01:33, Zoran Markovic wrote:
> > From: Shaibal Dutta <shaibal.dutta@broadcom.com>
>
> [...]
>
> > - schedule_delayed_work(&linkwatch_work, delay);
> > + queue_delayed_work(system_power_efficient_wq,
> > + &linkwatch_work, delay);
>
> before talking about technical details, here and in other spots of this
> patch the alignment is wrong. I think checkpatch should have said
> something about it. The first parameter on the new line should be
> aligned up to the column after the opening parenthesis.
Using "scripts/checkpatch.pl --strict" would emit an
alignment message, otherwise not.
prev parent reply other threads:[~2014-01-31 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 0:33 [RFC PATCH] net: core: move core networking work to power efficient workqueue Zoran Markovic
2014-01-31 0:48 ` Antonio Quartulli
2014-01-31 0:55 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391129701.2422.75.camel@joe-AO722 \
--to=joe@perches.com \
--cc=antonio@meshcoding.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zoran.markovic@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).