From: Olivier Langlois <olivier@trillion01.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, chaoming_li@realsil.com.cn,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mlang45@derytele.com
Subject: Re: [PATCH] rtl8192ce is disabling the irqs for too long
Date: Fri, 31 Jan 2014 00:16:08 -0500 [thread overview]
Message-ID: <1391145368.2436.249.camel@Wailaba2> (raw)
In-Reply-To: <52EAB3E6.2060809@lwfinger.net>
On Thu, 2014-01-30 at 14:19 -0600, Larry Finger wrote:
> On 01/30/2014 12:22 AM, Olivier Langlois wrote:
> > Signed-off-by: Olivier Langlois <olivier@trillion01.com>
> > ---
> > drivers/net/wireless/rtlwifi/ps.c | 2 +-
> > drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 18 ++++++++++++++++--
> > 2 files changed, 17 insertions(+), 3 deletions(-)
>
> Olivier,
>
> I like the fact that you have proposed a solution that has minimal effect on the
> other PCI drivers under rtlwifi. That certainly decreases the amount of testing
> needed. Of course, all of them may need the same kind of fix.
This has been done on purpose. I knew that you would appreciate. The
problem is probably present with the other cards but since I could not
validate or test the patch with them, I have left them unchanged. If you
were to determine that it apply to all of them then maybe the patch
could be moved to ps.c to wrap hw_init() call.
>
> The changes are certainly minimal; however, I do need to test them before giving
> my Ack.
>
> As the problem(s) fixed by this patch will affect stable kernels, you should add
> a "Cc: Stable <stable@vger.kernel.org>" patch.
>
> Originally, I was going to have you add a comment to the commit message on why
> you were changing the return value in rtl_ps_enable_nic(), but now I am thinking
> that this should be a separate commit as it fixes a totally different bug. Yes
> it is involved with the callback to hw_init, but the bug is independent.
done. I am about to resend the patch splitted into 2 commits.
>
> Good work on finding this problem.
>
my pleasure. it has been fun and gratifying.
prev parent reply other threads:[~2014-01-31 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 6:22 [PATCH] rtl8192ce is disabling the irqs for too long Olivier Langlois
2014-01-30 20:19 ` Larry Finger
2014-01-31 5:16 ` Olivier Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391145368.2436.249.camel@Wailaba2 \
--to=olivier@trillion01.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mlang45@derytele.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).